chore: set isolatedModules compilation option#2839
Merged
david-luna merged 5 commits intoopen-telemetry:mainfrom May 22, 2025
Merged
chore: set isolatedModules compilation option#2839david-luna merged 5 commits intoopen-telemetry:mainfrom
isolatedModules compilation option#2839david-luna merged 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
+ Coverage 89.62% 89.66% +0.03%
==========================================
Files 185 184 -1
Lines 9014 9010 -4
Branches 1849 1848 -1
==========================================
Hits 8079 8079
+ Misses 935 931 -4
🚀 New features to boost your workflow:
|
4 tasks
Contributor
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
This was referenced Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is a follow up PR on open-telemetry/opentelemetry-js#5697
IMHO the compilation options should be in sync if possible. Also TypeScript docs recommend to enable it to give better support for bundlers. It may benefit instrumentations targeting browser runtime.
Short description of the changes
isolatedModulesto true intsconfig.base.jsonexport type