chore: enable tsconfig isolatedModules#5697
Merged
david-luna merged 1 commit intoopen-telemetry:mainfrom May 21, 2025
Merged
Conversation
db90edc to
040ce3f
Compare
040ce3f to
b15c6ac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5697 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 310 310
Lines 7992 7998 +6
Branches 1614 1615 +1
=======================================
+ Hits 7595 7601 +6
Misses 397 397
🚀 New features to boost your workflow:
|
4 tasks
trentm
approved these changes
May 20, 2025
Contributor
trentm
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this!
Contributor
|
I think this is a good addition in order to start with #4744 |
Merged
via the queue into
open-telemetry:main
with commit May 21, 2025
7a9b049
19 of 20 checks passed
8 tasks
This was referenced Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Enables
isolatedModulesintsconfig.base.jsonRefs: #5691
Short description of the changes
No runtime side-effects are expected. This PR marks all type re-exports as
export type.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
npm run compilepassedChecklist: