feat: Browser Navigation Instrumentation#3148
feat: Browser Navigation Instrumentation#3148martinkuba merged 2 commits intoopen-telemetry:mainfrom
Conversation
a1fbf7d to
9ef7a8a
Compare
david-luna
left a comment
There was a problem hiding this comment.
that's a very good start :)
b4f4f99 to
42bfa43
Compare
overbalance
left a comment
There was a problem hiding this comment.
I would run npx prettier --write packages/instrumentation-browser-navigation as well.
|
@Abinet18 I forgot to mention that you should delete |
489169c to
a8e0c76
Compare
There was a problem hiding this comment.
I saw you resolved my comment about the example that relies on an older version of @opentelemetry/resources without responding. The examples don't work because of the deprecated syntax. I realize you didn't introduce that issue, and that all four examples need to be fixed. @martinkuba what do you advise?
I see the examples don't work when I reinstall and start. I have fixed the resource related code in all |
ec553ed to
68d5314
Compare
6c6b79b to
ef94c8b
Compare
|
Please add CHANGELOG file |
03260b3 to
9ba5069
Compare
35ff5a7 to
f018403
Compare
Which problem is this PR solving?
Creates a new instrumentation for browser navigation, in place of page view instrumentation that was being worked in this PR, with event defined in SemConv for this event
Short description of the changes