Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Updated zone.js version to support latest Angular #1930

Conversation

AndrewAKovalenko
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Update Zone.js version to support Angular 17

@AndrewAKovalenko AndrewAKovalenko requested a review from a team February 8, 2024 14:44
Copy link

linux-foundation-easycla bot commented Feb 8, 2024

CLA Missing ID CLA Not Signed

@AndrewAKovalenko
Copy link
Contributor Author

This PR is duplicate of #1926, but my PR prevents from major zone.js version update, by using ^

Also this PR is valuable for our team, so i'm always ready to make updates :)

@AndrewAKovalenko AndrewAKovalenko changed the title Updated zone.js version to support latest Angular chore(deps): Updated zone.js version to support latest Angular Feb 8, 2024
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AndrewAKovalenko, thanks for opening the PR. Some notes on the version range below. 🙂

Also, please sign the CLA, otherwise we won't be able to act on the PR.

@@ -32,7 +32,7 @@
},
"peerDependencies": {
"@opentelemetry/api": "^1.3.0",
"zone.js": "0.11.4"
"zone.js": "^0.11.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will allow for zone.js at >=0.11.4 and <0.12.0 - is that intended?
According to SemVer minor versions in a 0.x are considered breaking, therefore the caret does not do the same as with 1.x.

If you're trying to go to ^0.14.0 (Angular 17), please open a PR against the core repo first (related issue open-telemetry/opentelemetry-js#4445) - the dependency on zone.js here is transitive from there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you've already created PR open-telemetry/opentelemetry-js#4469
Thanks

I'll fix my PR to use same versions, as you do "zone.js": "^0.11.0 || ^0.13.0 || ^0.14.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds good.

Keep in mind, though, that we'll have to release the core repo first, then update the dependencies here, and once that's done we can merge this PR here. I'll take a few days.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, not a problem

@AndrewAKovalenko
Copy link
Contributor Author

@pichlermarc i've created similar PR with correct CLA verification. I accidentally used wrong git.config to sign it :)

#1934

Please, check it

Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[opentelemetry/auto-instrumentations-web 0.34.0] Update zone.js peer dependency
3 participants