[opentelemetry/auto-instrumentations-web 0.34.0] Update zone.js peer dependency #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dk-v3 instrumentation (open-telemetry#1913) As of smithy-lang/smithy-typescript#1146 (details at smithy-lang/smithy-typescript#1113) the CommonJS export for many (all?) `@smithy/*` packages is now an esbuild bundle -- all in `dist-cjs/index.js`. That means that subfile patching like this no longer works: ```js const v3SmithyMiddlewareStackFile = new InstrumentationNodeModuleFile( '@smithy/middleware-stack/dist-cjs/MiddlewareStack.js', ['>=1.0.1'], this.patchV3ConstructStack.bind(this), this.unpatchV3ConstructStack.bind(this) ); ``` In our case this breaks as of `@smithy/[email protected]` released 2024-01-17T22:26:42.432Z. This is considered a non-breaking change, so the dependency ranges for earlier released versions of `@smithy/smithy-client` will pick this up. A fix is to change the `@smithy/middleware-stack` patching to be on the top-level module exports. Because the `constructStack` field is only available as a getter we cannot use shimmer (InstrumentationBase._wrap). Instead this returns a new `moduleExports` object with a new getter that shims the call This PR also updates .tav.yml to reduce the number of aws-sdk package versions tested.
* chore: release main * chore: sync package-lock.json --------- Co-authored-by: opentelemetrybot <[email protected]>
|
|
github-actions
bot
assigned aabmass, basti1302, blumamir, dyladan, haddasbronfman, hectorhdzg, JamieDanielson, kirrg001 and legendecas
github-actions
bot
added
pkg:instrumentation-redis-4
pkg:instrumentation-redis
pkg:instrumentation-router
pkg:instrumentation-winston
pkg:instrumentation-document-load
pkg:instrumentation-long-task
pkg:instrumentation-user-interaction
pkg:plugin-react-load
pkg:propagator-aws-xray
pkg:propagator-instana
pkg:propagator-ot-trace
pkg:instrumentation-dataloader
pkg:instrumentation-socket.io
pkg:instrumentation-cucumber
pkg:sampler-aws-xray
pkg:resource-detector-container
pkg:resource-detector-azure
pkg:test-utils
pkg:redis-common
pkg:sql-common
labels
| @@ -75,7 +75,7 @@ | |||
| "webpack": "4.46.0", | |||
| "webpack-cli": "4.7.2", | |||
| "webpack-merge": "5.8.0", | |||
| "zone.js": "0.11.4" | |||
| "zone.js": "0.13.3" | |||
pichlermarc
requested changes
Feb 7, 2024
|
@pichlermarc created similar PR, but with couple of fixes |
|
Superseded by #1934 |
trentm
added
pkg:instrumentation-cassandra-driver
and removed
pkg:instrumentation-cassandra
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes