Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(context-zone*): support zone.js 0.13.x, 0.14.x #4469

Merged
merged 4 commits into from
Feb 12, 2024
Merged

feat(context-zone*): support zone.js 0.13.x, 0.14.x #4469

merged 4 commits into from
Feb 12, 2024

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

We've been behind on supporting recent zone.js versions, this PR adds support for 0.13.x and 0.14.x (used by Angular 17)

Fixes #4445
Fixes #4354

Short description of the changes

Type of change

How Has This Been Tested?

  • Existing tests

@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

Merging #4469 (ac72c9b) into main (f86251d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4469   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         330      330           
  Lines        9520     9520           
  Branches     2031     2031           
=======================================
  Hits         8799     8799           
  Misses        721      721

@AndrewAKovalenko AndrewAKovalenko mentioned this pull request Feb 9, 2024
Closed
@pichlermarc pichlermarc marked this pull request as ready for review February 9, 2024 13:12
@pichlermarc pichlermarc requested a review from a team February 9, 2024 13:12
@pichlermarc pichlermarc merged commit 25548fd into open-telemetry:main Feb 12, 2024
20 checks passed
@AndrewAKovalenko AndrewAKovalenko mentioned this pull request Feb 13, 2024
Merged
@pichlermarc pichlermarc mentioned this pull request Feb 23, 2024
Merged
This was referenced May 28, 2024
Open
Open
@thiruaws2lab thiruaws2lab mentioned this pull request Jun 12, 2024
Open
This was referenced Jun 15, 2024
Closed
Closed
Closed
This was referenced Jun 21, 2024
Open
Open
Open
@nnsutebu nnsutebu mentioned this pull request Jun 21, 2024
Open
This was referenced Jun 22, 2024
Closed
Closed
Closed
Closed
Closed
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
@pichlermarc @Zirak
feat(context-zone*): support zone.js 0.13.x, 0.14.x (open-telemetry#4469
c7022c2 
)

* feat(context-zone*): support zone.js 0.13.x, 0.14.x

* fix(changelog): add changelog entry

* fix(changelog): formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support zone.js v0.14.3 @opentelemetry/context-zone eradicates Promise.withResolvers
2 participants
@pichlermarc @trentm