Update Jaeger Exporter service name mapping in Go#1
Open
IrisTuntun wants to merge 3 commits intoopen-o11y:masterfrom
Open
Update Jaeger Exporter service name mapping in Go#1IrisTuntun wants to merge 3 commits intoopen-o11y:masterfrom
IrisTuntun wants to merge 3 commits intoopen-o11y:masterfrom
Conversation
Aneurysm9
approved these changes
Apr 6, 2021
|
|
||
| ### Compliance | ||
|
|
||
| - Update Jaeger Exporter service name mapping to be supported in Go. ([#TBD]) |
There was a problem hiding this comment.
I don't believe we've added CHANGELOG entries for spec compliance matrix updates. This probably isn't needed.
alolita
reviewed
Apr 6, 2021
alolita
left a comment
alolita
left a comment
There was a problem hiding this comment.
Whats the placeholder for in the changelog?
Author
The placeholder was for the PR number once I created the PR. Now I'm going to revert the CHANGELOG as Anthony suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Update Jaeger Exporter service name mapping in
spec-compliance-matrix.mdto be supported in Go.Related issue (open-telemetry/opentelemetry-go#1762)
Fixed by PR (open-telemetry/opentelemetry-go#1776)