controller: use consistent naming#1486
Closed
ldelossa wants to merge 49 commits intoopen-telemetry:mainfrom
Closed
controller: use consistent naming#1486ldelossa wants to merge 49 commits intoopen-telemetry:mainfrom
ldelossa wants to merge 49 commits intoopen-telemetry:mainfrom
Conversation
ldelossa
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
lizthegrey
as code owners
nit pr to utilize the same domain language across API boundaries. Signed-off-by: ldelossa <louis.delos@gmail.com>
ldelossa
force-pushed
the
louis/s-pusher-exporter
branch
from
f44fa0e to
27b5891
Compare
Aneurysm9
approved these changes
Feb 17, 2021
XSAM
approved these changes
Feb 17, 2021
Contributor
|
I tried merging main into this and look to have uncovered other upstream changes, sorry. @ldelossa are you able to resolve these issues? |
Contributor
Author
|
yup not a problem. |
…etry#1503) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.35.2 to 1.36.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.35.2...v1.36.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…jaeger (open-telemetry#1504) * Bump google.golang.org/api in /exporters/trace/jaeger Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.36.0 to 0.37.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.36.0...v0.37.0) Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Based on its module, it should be go.opencensus.io/otel/example/opencensus. However, it's simpler to get rid of it since main packages shouldn't be imported at all. Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
The minimum version of Go this project supports is 1.14 meaning that all supported versions of Go support the runtime/trace package. Remove specific build overrides for versions of Go prior to 1.11 that are not supported by this project.
…n-telemetry#1501) * Reverse order of attribute precedence when merging two Resources This reflects a change in the specification itself. open-telemetry/opentelemetry-specification#1345 * Resolves open-telemetry#1500 Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…jaeger (open-telemetry#1506) * Bump google.golang.org/api in /exporters/trace/jaeger Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.37.0 to 0.38.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.37.0...v0.38.0) Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Update README master branch URL to main * Remove master branch from workflow triggers The master branch has been renamed to main. * Add changes to CHANGELOG * Rename other projects default branch All of OpenTelemetry is moving to rename `master` to `main`, this updates all other URLs for those projects. Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
…metry#1488) Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…jaeger (open-telemetry#1517) * Bump google.golang.org/api in /exporters/trace/jaeger Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.38.0 to 0.39.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.38.0...v0.39.0) Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from v2 to v2.1.4. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2...26968a0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…n-telemetry#1528) * Add a tool to auto-generate replace directives * Auto-generated changes from previous commit * Create new modules required for trace release * otel/metric * otel/trace * otel/oteltest * otel/sdk/export/metric * otel/sdk/metric Relates to open-telemetry#1467 * Move metric-related public API out of otel/ pkg Move GetMeterProvider, Meter and SetMeterProvider to new package otel/metric/global in the otel/metric module. This will allow otel/ module to be released as v1.0. * Include PR references in CHANGELOG Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Check for root dir Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Prepare for releasing v0.17.0 * Update CHANGELOG
…en-telemetry#1507) * Create resource.Default() with required attributes/default values Add metric controller and tracer provider tests for resources * Updated CHANGELOG * PR comments + some small CHANGELOG PR addition, rewording + change default resource servicename to `unknown_service:go` (this matches the Java codebase which uses `unknown_service:java`)
* fix: grpc reconnection fixed * chore: changelog update * fix: grpc reconnection issue - red test * fix: grpc reconnection open-telemetry#1524 * fix: grpc reconnection issue cleanup
The spec makes it optional to attempt resampling when changing the name of a span and we're not sure whether it can be done in an appropriate manner, so it's best to not do it at all for now. We can try again later if we find a good way to do it.
* Rename otel/label -> otel/attr Leave the imported name alone, to avoid a large diff and conflicts * Better import comment * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * otel/attr -> otel/attribute * Missed the changelog entry * Get rid of import renaming * Merge remaining conflicts Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
…telemetry#1535) * Change the default span limit values to 128 * Rename and move MaxEventsPerSpan, MaxAttributesPerSpan, MaxLinksPerSpan into SpanLimits * Add AttributePerEventCountLimit and AttributePerLinkCountLimit * Update CHANGELOG * Apply suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Discard over limited attributes of links in `span.addLink` * Change the type of droppedAttributeCount to int64 * Fix tests * Fix label -> attribute package rename from merge Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <codingalias@gmail.com>
* Vendor Thrift dependency * Fix build * Changelog entry * Ignore third_party for coverage purposes * Re-run tests * Re-run tests * Re-run tests * Re-run tests * Relax time comparisons Fixes open-telemetry#1559. Some unit tests were flaking in CI because they expected the timestamp to advance during a test, when it's possible for it to be unchanged instead. This change switches the offending "<" comparisons to "<=". * Re-run tests * Relax more time comparisons * Re-run tests Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…etry#1565) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.36.0 to 1.37.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.36.0...v1.37.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update license-check to ignore all vendor dirs * Remove vendor path exclude from license-check find
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* add code attributes to semconv package * update changelog * update comment for code semconv attributes Adds a full-stop at the end of the comment. Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Stagger timestamps in exact aggregator tests Fixes open-telemetry#1559. * Missed one * Yield while you wait * Just sleep for a teeny tiny bit * Oops, wrong PR in Changelog * Make sure that *some* time passes * Keep time comparisons relaxed
* Fix stdout TestStdoutTimestamp failure with sleep Ensure the test condition is valid by introducing minimal sleep durations before and after a timestamp is measured. Resolves open-telemetry#1571 * Add changes to changelog Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
* Fix Windows build of Jaeger tests The Jaeger tests use the low-level syscall package. The Windows specific function called in that package has a different function signature than the unix version. Add a windows specific file using the build flags to isolate this OS specific functionality. * Add changes to changelog * Blind succeed to account for unimplemented functionality on Windows
…er (open-telemetry#1513) * Updating documentation with an working example for creating NewExporter * Updated Changelog * Moved examples in README to testing example * ExampleTest shouldn't log anything if working as expected * Fixing the lint * Fixing the lint * Review comments * Changes done moved to Fixed section of Changelog
"otel/exporters/otlp/otlphttp".Option "otel/exporters/stdout".Option "otel/oteltest".Option "otel/trace".TracerOption "otel/trace".SpanOption "otel/trace".EventOption "otel/trace".LifeCycleOption "otel/trace".InstrumentationOption "otel/sdk/resource".Option "otel/sdk/trace".ParentBasedSamplerOption "otel/sdk/trace".ReadOnlySpan "otel/sdk/trace".ReadWriteSpan Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Make timestamps sequential in lastvalue agg check * Set PR number in changelog * Fix location of sleep The lastvalue timestamp is set on update. Correct the location of the sleep to bridge the update of the two different aggregators.
…ry#1581) * Fix validation for tracestate with vendor * Add changes to changelog
…y#1620) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.35.0 to 1.36.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.35.0...v1.36.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pen-telemetry#1619) * Bump google.golang.org/grpc from 1.35.0 to 1.36.0 in /exporters/otlp Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.35.0 to 1.36.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.35.0...v1.36.0) Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Pass metric labels when transforming to gaugeArray * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Add label requirements to transformed metric assertions * Fix fmting Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…1621) * Use reasonable interval in sdktrace.WithBatchTimeout This patch resolves open-telemetry#1564. * Add pull request ID to CHANGELOG.md
* Add compatibility tests to CI * Increase timeout to 60s Some of the aggregator tests are running just over 30 seconds when testing on Windows. Bump this to allow for it. * Remove cache setup jobs Having a unified job setup the cache when none exists so packages are only downloaded once is ideal, but these steps are taking too long. In some situations they are doubling the run time. Remove them and prefer to have multiple downloads when dependencies change. * Add changes to changelog * Remove mod-download target from Makefile Unused now that the cache jobs are removed. * Add compatibility testing table to changelog * Add change about precommit to changelog * Update README * Correct examples target in lint job
Included all directives from the specification, clarify english, and translate specifics for the Go language.
* Rename local var new to not collide with builtin * Add missed var rename
* Prepare for releasing v0.18.0 * Update CHANGELOG for v0.18.0 release * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Add TracerProvider tests to oteltest harness * Update Tracer method docs * Fix grammar
ldelossa
force-pushed
the
louis/s-pusher-exporter
branch
from
7a63d90 to
06804d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.