Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Resource.Merge to be compliant with spec change #1500

Closed
evantorrie opened this issue Jan 29, 2021 · 0 comments · Fixed by #1501
Closed

Update Resource.Merge to be compliant with spec change #1500

evantorrie opened this issue Jan 29, 2021 · 0 comments · Fixed by #1501
Labels
area:resources Part of OpenTelemetry resources pkg:SDK Related to an SDK package
Milestone
untracked

Comments

@evantorrie
Copy link
Contributor

open-telemetry/opentelemetry-specification#1345 changed the specification to reverse the order in which Resource attributes are merged (updating resource takes precedence).

This needs to be changed in the Go implementation to conform to spec.
evantorrie added a commit to evantorrie/opentelemetry-go that referenced this issue Jan 29, 2021
@evantorrie
Resolves open-telemetry#1500
c24e1aa
@MrAlias MrAlias mentioned this issue Jan 29, 2021
Merged
@MrAlias MrAlias added area:resources Part of OpenTelemetry resources pkg:SDK Related to an SDK package priority:p1 labels Jan 29, 2021
MrAlias added a commit that referenced this issue Jan 29, 2021
@evantorrie @MrAlias
Reverse order of attribute precedence when merging two Resources (#1501)
1952d7b 
* Reverse order of attribute precedence when merging two Resources

This reflects a change in the specification itself.
open-telemetry/opentelemetry-specification#1345

* Resolves #1500

Co-authored-by: Tyler Yahn <[email protected]>
ldelossa pushed a commit to ldelossa/opentelemetry-go that referenced this issue Mar 5, 2021
@evantorrie @MrAlias @ldelossa
Reverse order of attribute precedence when merging two Resources (ope…
a4604cc 
…n-telemetry#1501)

* Reverse order of attribute precedence when merging two Resources

This reflects a change in the specification itself.
open-telemetry/opentelemetry-specification#1345

* Resolves open-telemetry#1500

Co-authored-by: Tyler Yahn <[email protected]>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:resources Part of OpenTelemetry resources pkg:SDK Related to an SDK package
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Reverse order of attribute precedence when merging two Resources evantorrie/opentelemetry-go
3 participants
@pellared @MrAlias @evantorrie