-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows build of Jaeger tests #1577
Conversation
The Jaeger tests use the low-level syscall package. The Windows specific function called in that package has a different function signature than the unix version. Add a windows specific file using the build flags to isolate this OS specific functionality.
Codecov Report
@@ Coverage Diff @@
## main #1577 +/- ##
=======================================
- Coverage 78.0% 78.0% -0.1%
=======================================
Files 127 128 +1
Lines 6597 6606 +9
=======================================
+ Hits 5151 5155 +4
- Misses 1201 1204 +3
- Partials 245 247 +2
|
Looking further into the error message from the actual test run, it looks like this will always fail on Windows. The network file descriptor is not available from the connection on Windows. A I'm going to updated this to return just return |
* Fix Windows build of Jaeger tests The Jaeger tests use the low-level syscall package. The Windows specific function called in that package has a different function signature than the unix version. Add a windows specific file using the build flags to isolate this OS specific functionality. * Add changes to changelog * Blind succeed to account for unimplemented functionality on Windows
The Jaeger tests use the low-level syscall package. The Windows specific function called in that package has a different function signature than the unix version. Add a windows specific file using the build flags to isolate this OS specific functionality.
I'm able to verify this fixes the compilation of the testing package and the test failure on a Windows system:
Resolves #1576