Skip to content

Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.61.0#20017

Merged
ahrtr merged 4 commits intoetcd-io:mainfrom
dims:update-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc-to-v0.61.0
May 26, 2025
Merged

Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.61.0#20017
ahrtr merged 4 commits intoetcd-io:mainfrom
dims:update-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc-to-v0.61.0

Conversation

@dims
Copy link
Contributor

@dims dims commented May 23, 2025

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc now has a new v0.61.0.

the changelog calls out the following:

xref: kubernetes/kubernetes#131942

@dims dims force-pushed the update-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc-to-v0.61.0 branch from 0056114 to 619c1d5 Compare May 23, 2025 16:03
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (622a010) to head (6137568).
Report is 13 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/v3rpc/grpc.go 95.00% <100.00%> (-0.13%) ⬇️

... and 23 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #20017   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files         424      424           
  Lines       35762    35756    -6     
=======================================
- Hits        24602    24600    -2     
- Misses       9737     9739    +2     
+ Partials     1423     1417    -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 622a010...6137568. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dims dims force-pushed the update-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc-to-v0.61.0 branch from 619c1d5 to ddfce9c Compare May 23, 2025 17:27
@dims dims force-pushed the update-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc-to-v0.61.0 branch from ddfce9c to bea5735 Compare May 23, 2025 18:26
…grpc/otelgrpc to v0.61.0

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the update-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc-to-v0.61.0 branch from bea5735 to 457c218 Compare May 23, 2025 19:03
@dims dims changed the title [WIP] update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.61.0 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.61.0 May 24, 2025
@dims
Copy link
Contributor Author

dims commented May 24, 2025

/assign @ahrtr @serathius

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims changed the title Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.61.0 [wip] Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.61.0 May 24, 2025
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the update-go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc-to-v0.61.0 branch from 98d1f0e to 7728d8f Compare May 24, 2025 17:09
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims changed the title [wip] Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.61.0 Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to v0.61.0 May 24, 2025
@k8s-ci-robot
Copy link

@dims: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci-etcd-robustness-release36-amd64 6137568 link true /test ci-etcd-robustness-release36-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dims
Copy link
Contributor Author

dims commented May 24, 2025

@ahrtr as you rightly pointed out, ci-etcd-robustness-release36-amd64 is the only one failing now.

@ahrtr
Copy link
Member

ahrtr commented May 25, 2025

@ahrtr as you rightly pointed out, ci-etcd-robustness-release36-amd64 is the only one failing now.

@dims Just fixed that failure in #20019. Let's wait for kubernetes/test-infra#34848 to be merged, after that you can rebase this PR.

@dims
Copy link
Contributor Author

dims commented May 25, 2025

/skip

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! thx @dims

We may also want to add a changelog item for 3.7 under section "etcd server" (pls add the section between "Breaking Changes" and "Package pkg". Pls feel free to do it in this PR or in a followup PR.

@ahrtr
Copy link
Member

ahrtr commented May 25, 2025

cc @ivanvc @jmhbnz @serathius take a second look.

@dims
Copy link
Contributor Author

dims commented May 25, 2025

@ahrtr thanks will file another PR once this lands.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, dims, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit b7db556 into etcd-io:main May 26, 2025
35 checks passed
ahrtr added a commit that referenced this pull request May 28, 2025
…pstream-release-3.6-take-2

Semi-Automated cherry pick of #20017 upstream release 3.6 ( was Update go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc to work with v0.61.0 )
@ivanvc ivanvc mentioned this pull request May 28, 2025
4 tasks
@ivanvc ivanvc mentioned this pull request Jul 6, 2025
2 tasks
@ivanvc ivanvc mentioned this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants