Migrate to semconv for otelmux and implement the package in tracing#6652
Merged
dmathieu merged 10 commits intoFeb 3, 2025
Merged
Conversation
Contributor
Author
|
I had to delete the semconv |
Contributor
Author
Solved by adding a parameter in the template. |
Member
|
Thank you for the template fix. I've extracted it into another PR, so other instrumentations aren't blocked by this one. #6663 |
semconv for otelmux and implement the package in tracing
15a23fb to
100f343
Compare
100f343 to
281e23d
Compare
dmathieu
reviewed
Jan 27, 2025
6251f77 to
6d3e80b
Compare
dmathieu
reviewed
Jan 28, 2025
Member
|
This will need a changelog entry. |
dmathieu
reviewed
Jan 28, 2025
3ff7e4e to
b1225a4
Compare
Contributor
|
Will review after body wrapper is merged/included |
Member
|
Can you fix the conflicts that were introduced with the merge of your other PR? |
Contributor
Author
dmathieu
reviewed
Jan 30, 2025
dmathieu
approved these changes
Jan 30, 2025
akats7
reviewed
Feb 2, 2025
akats7
approved these changes
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
otelmuxpackage by introducing thesemconvpackage and using it withtracingonly. It also updates the template and refines thegen.goinotelhttpto reflect the changes made in the template.This PR addresses feedback provided in #6648