Skip to content

Make the package dynamic in internal/shared/semconv#6663

Merged
dmathieu merged 3 commits into
open-telemetry:mainfrom
dmathieu:shared-semconv-pkg
Jan 25, 2025
Merged

Make the package dynamic in internal/shared/semconv#6663
dmathieu merged 3 commits into
open-telemetry:mainfrom
dmathieu:shared-semconv-pkg

Conversation

@dmathieu
Copy link
Copy Markdown
Member

We need a dynamic package name in internal/shared/semconv, as we can't call the otelhttp/internal/semconvutil package and need to call the package from the instrumentation itself.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jan 22, 2025
@dmathieu dmathieu marked this pull request as ready for review January 22, 2025 08:50
@dmathieu dmathieu requested a review from a team as a code owner January 22, 2025 08:50
@MrAlias MrAlias added this to the v1.35.0 milestone Jan 22, 2025
@dmathieu
Copy link
Copy Markdown
Member Author

Ping @open-telemetry/go-approvers for review.

Comment thread instrumentation/net/http/otelhttp/internal/semconv/gen.go
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.0%. Comparing base (38dcccc) to head (5ea5dff).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6663   +/-   ##
=====================================
  Coverage   73.0%   73.0%           
=====================================
  Files        189     189           
  Lines      15773   15773           
=====================================
+ Hits       11519   11522    +3     
+ Misses      3920    3918    -2     
+ Partials     334     333    -1     

see 1 file with indirect coverage changes

@dmathieu dmathieu merged commit 2425189 into open-telemetry:main Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

Development

Successfully merging this pull request may close these issues.

4 participants