Make the package dynamic in internal/shared/semconv#6663
Merged
Conversation
pellared
approved these changes
Jan 22, 2025
MrAlias
approved these changes
Jan 22, 2025
Member
Author
|
Ping @open-telemetry/go-approvers for review. |
XSAM
reviewed
Jan 24, 2025
XSAM
approved these changes
Jan 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6663 +/- ##
=====================================
Coverage 73.0% 73.0%
=====================================
Files 189 189
Lines 15773 15773
=====================================
+ Hits 11519 11522 +3
+ Misses 3920 3918 -2
+ Partials 334 333 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a dynamic package name in
internal/shared/semconv, as we can't call the otelhttp/internal/semconvutil package and need to call the package from the instrumentation itself.