Skip to content

feat: support metrics for otelmux#6648

Merged
dmathieu merged 9 commits into
open-telemetry:mainfrom
martinyonatann:feat/migrate-to-semconv-for-otelmux
Feb 5, 2025
Merged

feat: support metrics for otelmux#6648
dmathieu merged 9 commits into
open-telemetry:mainfrom
martinyonatann:feat/migrate-to-semconv-for-otelmux

Conversation

@martinyonatann
Copy link
Copy Markdown
Contributor

Address issue #6638

@martinyonatann martinyonatann requested a review from a team as a code owner January 19, 2025 18:39
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jan 19, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions Bot requested a review from akats7 January 19, 2025 18:39
@dmathieu
Copy link
Copy Markdown
Member

Thank you for this! ❤️

This PR does a lot more than just setup semconv.
In order to allow for better reviews, could you split it into multiple PRs?
From a first look, I'd do at least four:

  • Setup the body wrapper and use it.
  • Change the default span name behavior.
  • Introduce the semconv package, and use it with tracing only.
  • Introduce metrics support.

Striving for atomic PRs (each PR changes a single thing) makes for much speeder reviews.

@martinyonatann
Copy link
Copy Markdown
Contributor Author

martinyonatann commented Jan 20, 2025

thankyou for the feedback @dmathieu ! ❤️
You're absolutely right, this PR ended up covering more ground than initially intended. i appreciate your suggestion to split it into atomic PRs for easier review. i'll get started on breaking it down into the following :

This approach should make the review process smother and more efficient. i'll prioritize reorganizing these changes and will submit the individual PRs soon. Let me know if there are any additional points you'd like me to address.

@dmathieu dmathieu marked this pull request as draft January 20, 2025 09:27
@martinyonatann martinyonatann force-pushed the feat/migrate-to-semconv-for-otelmux branch from 50b35e9 to 379f764 Compare January 27, 2025 06:34
@martinyonatann martinyonatann changed the title migrate to semconv for otelmux #6638 migrate to semconv for otelmux and implementation the package in metrics Jan 27, 2025
@martinyonatann martinyonatann force-pushed the feat/migrate-to-semconv-for-otelmux branch from 379f764 to 225115d Compare January 30, 2025 14:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9%. Comparing base (6676f17) to head (c2fe973).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #6648     +/-   ##
=======================================
+ Coverage   73.8%   73.9%   +0.1%     
=======================================
  Files        195     195             
  Lines      16627   16671     +44     
=======================================
+ Hits       12285   12335     +50     
+ Misses      3982    3978      -4     
+ Partials     360     358      -2     
Files with missing lines Coverage Δ
...mentation/github.com/gorilla/mux/otelmux/config.go 100.0% <100.0%> (ø)
...trumentation/github.com/gorilla/mux/otelmux/mux.go 95.5% <100.0%> (+1.5%) ⬆️

... and 1 file with indirect coverage changes

@martinyonatann martinyonatann changed the title migrate to semconv for otelmux and implementation the package in metrics feat: support metrics for otelmux Jan 30, 2025
@martinyonatann martinyonatann marked this pull request as ready for review January 31, 2025 18:02
Comment thread instrumentation/github.com/gorilla/mux/otelmux/mux.go Outdated
Comment thread CHANGELOG.md Outdated
Co-authored-by: Damien Mathieu <42@dmathieu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants