reporter: fix OTel SemConv#551
Merged
christos68k merged 1 commit intomainfrom Jun 26, 2025
Merged
Conversation
Update OTel SemConv dependency and fix SemConv keys accordingly. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
commented
Jun 26, 2025
| attrMgr.AppendOptionalString( | ||
| sample.AttributeIndices(), | ||
| attribute.Key("env."+key), | ||
| attribute.Key("process.environment_variable."+key), |
Member
Author
There was a problem hiding this comment.
Manually using the SemConv attribute process.environment_variable.<KEY> here, as it is missing as part of the dependency. See open-telemetry/opentelemetry-go#6934.
rockdaboot
approved these changes
Jun 26, 2025
christos68k
approved these changes
Jun 26, 2025
This was referenced Jul 8, 2025
This was referenced Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update OTel SemConv dependency and fix SemConv keys accordingly.
While the dependency got updated with 0981fa5, relevant code was not updated accordingly.