pdata/generate: Simplify deduplication logic / add Location deduplication#550

Merged

christos68k merged 6 commits intomainfrom

Jun 27, 2025

Member

christos68k commented Jun 26, 2025 •

edited

Loading

Summary

Fixed bug in tests
Better error handling (avoids dictionary corruption)
Added pdata.OrderedSet
Various cleanups and simplifications

TODO: ~~Deduplicate Locations~~ DONE

Also see:

reporter: implement Location deduplication #515
reporter: respect existing elements in dictionary #538
Fix location_table access pattern elastic/devfiler#27 (You need to apply this if testing with devfiler)

christos68k requested review from a team as code owners

June 26, 2025 04:11

christos68k self-assigned this

christos68k linked an issue

that may be closed by this pull request

reporter: implement Location deduplication #515

Closed

christos68k marked this pull request as draft

June 26, 2025 04:12

christos68k mentioned this pull request

reporter: respect existing elements in dictionary #538

Closed

christos68k force-pushed the ck/dedup branch from 52e412e to bf48223 Compare

June 26, 2025 04:19

florianl reviewed

View reviewed changes

libpf/generics.go Outdated

libpf/generics.go Outdated

rockdaboot reviewed

View reviewed changes

reporter/internal/pdata/generate.go Outdated

rockdaboot reviewed

View reviewed changes

reporter/internal/pdata/generate.go Outdated

rockdaboot reviewed

View reviewed changes

reporter/internal/pdata/generate.go

rockdaboot reviewed

View reviewed changes

reporter/internal/pdata/generate.go

rockdaboot reviewed

View reviewed changes

libpf/generics.go Outdated

christos68k mentioned this pull request

Fix location_table access pattern elastic/devfiler#27

Merged

christos68k changed the title ~~pdata/generate: Simplify deduplication logic~~ pdata/generate: Simplify deduplication logic / add Location deduplication

christos68k force-pushed the ck/dedup branch from cd018a3 to 5a26d33 Compare

June 26, 2025 22:24

christos68k marked this pull request as ready for review

June 26, 2025 23:01

christos68k mentioned this pull request

Enable gzip compression for Export RPC (otlp_reporter) #554

Merged

christos68k linked an issue

that may be closed by this pull request

setProfile() only works with one Profile per message #534

Closed

christos68k mentioned this pull request

setProfile() only works with one Profile per message #534

Closed

florianl reviewed

View reviewed changes

reporter/internal/pdata/generate_test.go Outdated

florianl approved these changes

View reviewed changes

Member

florianl left a comment

Tested with elastic/devfiler#27

christos68k added 6 commits

June 27, 2025 08:13


          Add libpf.OrderedSet

f2f577e


          pdata/generate: Rework on top of libpf.OrderedSet

- Fixed bug in tests
- Better error handling (avoids corruption of dictionaries)
- Simplified/reduced code


          pdata/generate: Deduplicate Locations

2fd4364


          Move libpf.OrderedSet to reporter/internal/pdata


          pdata: Cleanups and simplifications

f987eb5


          Update otel/semconv to v1.34.0

ada2bb2

christos68k force-pushed the ck/dedup branch from 343b2b4 to ada2bb2 Compare

June 27, 2025 12:14

rockdaboot approved these changes

View reviewed changes

Contributor

rockdaboot left a comment •

edited

Loading

Tested with OTEL collector + ES 9.2.0-SNAPSHOT (had to fix two serious issues and add one missing feature in/for elasticsearchexporter) 😅

christos68k merged commit 6f2a545 into main

25 checks passed

christos68k deleted the ck/dedup branch

June 27, 2025 13:26

This was referenced Jul 8, 2025

Update with changes from upstream parca-dev/opentelemetry-ebpf-profiler#74

Merged

fix jits parca-dev/opentelemetry-ebpf-profiler#75

Closed

christos68k mentioned this pull request

Profiler generates multiple unique dummy mappings #597

Closed

This was referenced Aug 14, 2025

fix golabels tests parca-dev/opentelemetry-ebpf-profiler#92

Closed

fix golabels test parca-dev/opentelemetry-ebpf-profiler#97

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet