Skip to content

reporter: fix OTel SemConv #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christos68k merged 1 commit into from
Jun 26, 2025
+4 −4
Merged

reporter: fix OTel SemConv #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions reporter/internal/pdata/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"go.opentelemetry.io/collector/pdata/pprofile"
"go.opentelemetry.io/otel/attribute"

semconv "go.opentelemetry.io/otel/semconv/v1.30.0"
semconv "go.opentelemetry.io/otel/semconv/v1.34.0"

"go.opentelemetry.io/ebpf-profiler/libpf"
"go.opentelemetry.io/ebpf-profiler/reporter/samples"
Expand Down Expand Up @@ -162,7 +162,7 @@ func (p *Pdata) setProfile(
// semantic convention for build_id, replace these hard coded
// strings.
attrMgr.AppendOptionalString(mapping.AttributeIndices(),
semconv.ProcessExecutableBuildIDGnuKey,
semconv.ProcessExecutableBuildIDGNUKey,
ei.GnuBuildID)
attrMgr.AppendOptionalString(mapping.AttributeIndices(),
semconv.ProcessExecutableBuildIDHtlhashKey,
Expand Down Expand Up @@ -226,7 +226,7 @@ func (p *Pdata) setProfile(
for key, value := range traceInfo.EnvVars {
attrMgr.AppendOptionalString(
sample.AttributeIndices(),
attribute.Key("env."+key),
attribute.Key("process.environment_variable."+key),
Copy link
Copy Markdown
Member Author

@florianl florianl Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually using the SemConv attribute process.environment_variable.<KEY> here, as it is missing as part of the dependency. See open-telemetry/opentelemetry-go#6934.

value)
}

Expand Down
2 changes: 1 addition & 1 deletion reporter/samples/attrmgr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/pprofile"
"go.opentelemetry.io/ebpf-profiler/libpf"
semconv "go.opentelemetry.io/otel/semconv/v1.30.0"
semconv "go.opentelemetry.io/otel/semconv/v1.34.0"
)

type attributeStruct struct {
Expand Down