Repository navigation
[Resources.Azure] Add App Service account and resource group attributes - #5138
Conversation
|
Welcome, contributor! Thank you for your contribution to opentelemetry-dotnet-contrib. Important reminders:
|
Signed-off-by: E. Lewis <7704925+Lewis-E@users.noreply.github.com>
b36d7f1 to
05ea9b7
Compare
Signed-off-by: E. Lewis <7704925+Lewis-E@users.noreply.github.com>
Signed-off-by: E. Lewis <7704925+Lewis-E@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5138 +/- ##
=======================================
Coverage 78.39% 78.40%
=======================================
Files 497 497
Lines 20877 20884 +7
=======================================
+ Hits 16367 16374 +7
Misses 4510 4510
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: E. Lewis <7704925+Lewis-E@users.noreply.github.com>
|
While looking at this I spotted #5143, and then in the process of looking for any further issues Claude Code noted the following with regards to this PR:
Would you like to include changes for those in this PR too (or open additional PRs for those later)? |
|
@martincostello I was planning separate PRs for Azure Container Apps and Azure Functions, with AF soon and Azure Container Apps a while later. Would you prefer them all together? I can include Azure VMs too. |
|
Separate is fine - I just thought I'd mention it while it was a draft. |
Changes
Update the Azure App Service resource detector to emit:
cloud.account.id- fromWEBSITE_OWNER_NAME[sem-conv]azure.resource_group.name- fromWEBSITE_RESOURCE_GROUP[sem-conv]Also include these values as params for
GetAzureResourceURIinstead of parsing them inside the uri function.Goal: Align the .NET detector with the Azure App Service mapping tracked in collector-contrib #49616 and implemented for the Collector in collector-contrib #50287.
AI Disclosure: Pi Coding Agent was used to draft this PR, but I wrote this PR description and can explain all changes.
Testing
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes