Repository navigation
Conversation
Lewis-E
changed the title
Lewis-E
changed the title
47dfbc9 to
905d409
Compare
Pull request dashboard statusWaiting on reviewers · refreshed 2026-10-17 03:55 UTC Review the latest changes. Status above doesn't look right?
|
|
@Lewis-E was this mapping reviewed or confirmed by an Azure/Microsoft domain owner? If so, could you link that discussion or approval? I can see this code is being added across the place in OpneTelemetry and I was not aware of any discussion about this |
|
@hectorhdzg If you're looking across the repos, you've probably traced the PR discussions already: Here are the semantic convention discussions:
There were several sem-conv SIG discussions with at least one Microsoft/Azure domain owner present, both to get the above items approved, and later, to raise this issue: open-telemetry/opentelemetry-go-contrib#9564 -- you'll see both Kathie (above PRs) and me as attendees. Here are the initial implementations:
Let me know if you have any questions or recommendations. There's areas (Flex Consumption Azure Functions in particular) where I'd love to discuss things outside of this PR. |
…butes Emit the Azure subscription and resource group independently, and use the current deployment environment attribute name. Assisted-by: OpenAI GPT-5.4 Signed-off-by: E. Lewis <7704925+Lewis-E@users.noreply.github.com>
Assisted-by: OpenAI GPT-5.4 Signed-off-by: E. Lewis <7704925+Lewis-E@users.noreply.github.com>
Assisted-by: OpenAI GPT-5.4 Signed-off-by: E. Lewis <7704925+Lewis-E@users.noreply.github.com>
Signed-off-by: E. Lewis <7704925+Lewis-E@users.noreply.github.com>
905d409 to
3f2efe7
Compare
|
@Lewis-E thanks for your contribution, we are creating internal document for these attributes in Microsoft side, we will review all your PRs soon, including Node.js and Python, thanks for your patience |
|
@hectorhdzg I expect to do a third set of PRs around azure container apps in the next ~2-3 weeks, if that impacts your documentation at all, just letting you know. Thank you for letting me know about the internal docs-- happy for process to wind its way to completion. |
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
@hectorhdzg Going to un-stale this by checking in :) |
This branch has not been deployed
2 participants
Description
Update the Azure App Service resource detector to emit:
cloud.account.id- fromWEBSITE_OWNER_NAME[sem-conv]azure.resource_group.name- fromWEBSITE_RESOURCE_GROUP[sem-conv]deployment.environment.name- Same as pre-existingdeployment.environment, but with the stable sem-conv key. [sem-conv]Goal: Align the Python detector with the Azure App Service mapping tracked in collector-contrib #49616 and implemented for the Collector in collector-contrib #50287.
AI Disclosure: Pi Coding Agent was used to draft this PR, but I wrote this PR description and can explain all changes.
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.