Skip to content

[Resources.Azure] Update Azure attribute values - #5143

Merged
martincostello merged 5 commits into
open-telemetry:mainfrom
martincostello:fix-azure-semconv
Aug 28, 2026
Merged

martincostello merged 5 commits into
open-telemetry:mainfrom
martincostello:fix-azure-semconv

Conversation

@martincostello

@martincostello martincostello commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

Changes

React to changes made in v1.35.0 of the semantic conventions by open-telemetry/semantic-conventions#1698 for cloud.platform:

  • Update azure_app_service to azure.app_service.
  • Update azure_vm to azure.vm.
  • Update azure_container_apps to azure.container_apps.

Spotted while reviewing #5138 via open-telemetry/opentelemetry-collector-contrib#49616.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

React to changes made in v1.35.0 of the semantic conventions:

- Update `azure_app_service` to `azure.app_service`.
- Update `azure_vm` to `azure.vm`.
- Update `azure_container_apps` to `azure.container_apps`.
@github-actions github-actions Bot added the comp:resources.azure Things related to OpenTelemetry.Resources.Azure label Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.15%. Comparing base (3ff8fe2) to head (e7fb2e0).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5143      +/-   ##
==========================================
- Coverage   78.46%   78.15%   -0.31%     
==========================================
  Files         497      484      -13     
  Lines       20884    20529     -355     
==========================================
- Hits        16387    16045     -342     
+ Misses       4497     4484      -13     
Flag Coverage Δ
unittests-Resources.Azure 84.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/OpenTelemetry.Resources.Azure/CHANGELOG.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns Azure resource detectors with current OpenTelemetry semantic conventions.

Changes:

  • Updates three cloud.platform values to dotted Azure identifiers.
  • Synchronizes README documentation and changelog.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
ResourceAttributeConstants.cs Updates Azure platform constants.
README.md Documents the updated values.
CHANGELOG.md Records the behavioral change.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/OpenTelemetry.Resources.Azure/ResourceAttributeConstants.cs
Comment thread src/OpenTelemetry.Resources.Azure/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry.Resources.Azure/CHANGELOG.md Outdated
Update CHANGELOG grammar.
Do not re-use the same constants as the production code.
@martincostello
martincostello marked this pull request as ready for review August 28, 2026 16:13
@martincostello
martincostello requested a review from a team as a code owner August 28, 2026 16:13
@martincostello
martincostello added this pull request to the merge queue Aug 28, 2026
Merged via the queue into open-telemetry:main with commit 0678b9e Aug 28, 2026
76 checks passed
@martincostello
martincostello deleted the fix-azure-semconv branch August 28, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:resources.azure Things related to OpenTelemetry.Resources.Azure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants