AWS Lambda wrapper enhancements: Trace methods enhancements and Activity creation behaviour changes. #408

rypdal · 2022-06-08T15:32:34Z

Changes

Extended public Trace methods of the AWSLambdaWrapper class with additional optional parameter: parent context which is used further for ActivitySource.StartActivity(...) call.
If the parent context is not provided to one of Trace methods from the AWSLambdaWrapper then parent is extracted from the incoming request if it's type is either APIGatewayProxyRequest or APIGatewayHttpApiV2ProxyRequest (both from Amazon.Lambda.APIGatewayEvents namespace). Corresponding method ExtractParentContext has been added to the AWSLambdaUtils class.
Changed behaviour of the OnFunctionStart method: Activity is created even if the parent context isn't defined.
Breaking change: AWSLambdaWrapper.Trace overloads without ILambdaContext argument have been completely removed. All current AWS lambda triggers provide ILambdaContext hence it's always possible to pass it from customer's code. The ILambdaContext is used further for function default tags definition.
Two additional AWSLambdaWrapper.Trace overloads without generic input arguments have been added for the case of functions with only ILambdaContext as input.

- added optional parent context and tags parameters to tracing methods of AWSLambdaWrapper - changed parent related behaviour of OnFunctionStart method - added option flag for ignoring X-Ray propagation

…lback when parent context is not provided (open-telemetry#403)

codecov · 2022-06-08T15:48:23Z

Codecov Report

Merging #408 (cc51acf) into main (2c57ff0) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main    #408   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        167     168    +1     
  Lines       5100    5125   +25     
=====================================
- Misses      5100    5125   +25

Impacted Files	Coverage Δ
...ation.AWSLambda/AWSLambdaInstrumentationOptions.cs	`0.00% <0.00%> (ø)`
...ntation.AWSLambda/Implementation/AWSLambdaUtils.cs	`0.00% <0.00%> (ø)`
...ation.AWSLambda/Implementation/AWSLambdaWrapper.cs	`0.00% <0.00%> (ø)`
...ation.AWSLambda/TracerProviderBuilderExtensions.cs	`0.00% <0.00%> (ø)`

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaWrapper.cs

…e function trigger and lambda context 2. added parent context extraction for http triggered AWS Lambdas 3. aligned unit tests accordingly (open-telemetry#403)

…pen-telemetry#403)

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaWrapper.cs

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaUtils.cs

…ls.GetFunctionDefaultTags and used them for Activity creation - refactored AWSLambdaWrapper.Trace methods: removed duplicate code - extended Trace methods xml-doc (open-telemetry#403)

utpilla · 2022-07-14T00:15:09Z

@srprash Could you please review this PR?

- made ILambdaContext argument mandatory - removed Trace methods without ILambdaContext - added Trace overloads without input argument (input only with ILambdaContext)

…open-telemetry#403)

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaWrapper.cs

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaUtils.cs

…etry#403)

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaUtils.cs

…tion/AWSLambdaWrapper.cs review (open-telemetry#403) Co-authored-by: Christian Neumüller <[email protected]>

…/github.com/rypdal/opentelemetry-dotnet-contrib into issue/AWS-Lambda-wrapper-and-parent-context

Oberon00

Thank you for addressing all my comments!

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaWrapper.cs

…tion/AWSLambdaWrapper.cs Co-authored-by: Christian Neumüller <[email protected]>

Oberon00 · 2022-08-04T08:23:05Z

Hello! From my and @rypdal's perspective, this PR would be ready for merging.

utpilla · 2022-08-04T16:52:40Z

Please add a CHANGELOG entry and we can merge this.

rypdal · 2022-08-05T08:41:01Z

Please add a CHANGELOG entry and we can merge this.

@utpilla: CHANGELOG entry has been added.

utpilla · 2022-08-05T17:54:14Z

@rypdal Please follow the steps mentioned here if you want to request a package release: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package

rypdal · 2022-08-08T15:38:14Z

Thanks to @Oberon00 for the review !

rypdal added 3 commits June 7, 2022 18:03

open-telemetry#403

2e8d92f

- added optional parent context and tags parameters to tracing methods of AWSLambdaWrapper - changed parent related behaviour of OnFunctionStart method - added option flag for ignoring X-Ray propagation

- removed flag for ignoring x-ray propagation: x-ray is used as a fal…

bbf6448

…lback when parent context is not provided (open-telemetry#403)

extended AWSLambdaWrapper unit tests (open-telemetry#403)

f7a3571

rypdal requested a review from a team June 8, 2022 15:32

rypdal changed the title ~~AWS Lambda wrapper enhancements (issue #403)~~ AWS Lambda wrapper enhancements: Trace methods enhancements and Activity creation behaviour changes. Jun 8, 2022

utpilla added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label Jun 8, 2022

rypdal added 2 commits June 9, 2022 11:43

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

78649d6

Added workaround IgnoreAWSXRayPropagation flag (open-telemetry#403).

ad6d9b2

rypdal commented Jun 9, 2022

View reviewed changes

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaWrapper.cs Outdated Show resolved Hide resolved

rypdal added 9 commits June 10, 2022 09:53

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

41e7583

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

be71276

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

2c8f907

1. removed tags parameter: default function tags are derived from typ…

2ca5828

…e function trigger and lambda context 2. added parent context extraction for http triggered AWS Lambdas 3. aligned unit tests accordingly (open-telemetry#403)

Removed unused using (open-telemetry#403)

13c47cd

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

03ff4e1

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

bef83c3

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

8ef6345

Added support of API Gateway HTTP API version 2 payload proxy format (o…

40b8087

…pen-telemetry#403)

Oberon00 reviewed Jul 5, 2022

View reviewed changes

rypdal added 4 commits July 11, 2022 11:40

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

2e0ee96

- moved setting of function tags from OnFunctionStart to AWSLambdaUti…

3ae0b9f

…ls.GetFunctionDefaultTags and used them for Activity creation - refactored AWSLambdaWrapper.Trace methods: removed duplicate code - extended Trace methods xml-doc (open-telemetry#403)

- updated phrasing in xml-doc (open-telemetry#403)

746c1e5

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

9b0dc24

rypdal added 5 commits July 20, 2022 11:34

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

94d7cc6

(open-telemetry#403)

6591210

- made ILambdaContext argument mandatory - removed Trace methods without ILambdaContext - added Trace overloads without input argument (input only with ILambdaContext)

- review suggestion: keep empty headers (open-telemetry#403)

564fb28

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

3cc4629

AWS Lambda unit tests refactoring: renaming, removing redundant tests (…

274e6ba

…open-telemetry#403)

Oberon00 reviewed Jul 28, 2022

View reviewed changes

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

9ea5d18

github-actions bot assigned Oberon00 and rypdal Jul 29, 2022

- simplification: replace array copy with linq expression (open-telem…

72bf5c0

…etry#403)

Oberon00 reviewed Jul 29, 2022

View reviewed changes

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaUtils.cs Outdated Show resolved Hide resolved

rypdal and others added 5 commits July 29, 2022 10:21

applied improvements from review (open-telemetry#403)

aa4ec43

Update src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementa…

226b405

…tion/AWSLambdaWrapper.cs review (open-telemetry#403) Co-authored-by: Christian Neumüller <[email protected]>

added minor suggestions (open-telemetry#403)

0a304a4

Merge branch 'issue/AWS-Lambda-wrapper-and-parent-context' of https:/…

3605aea

…/github.com/rypdal/opentelemetry-dotnet-contrib into issue/AWS-Lambda-wrapper-and-parent-context

- renamed the method to avoid confusions (open-telemetry#403)

76fc16c

Oberon00 approved these changes Jul 29, 2022

View reviewed changes

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaWrapper.cs Outdated Show resolved Hide resolved

src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaWrapper.cs Outdated Show resolved Hide resolved

rypdal and others added 3 commits July 29, 2022 17:11

Update src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementa…

c114fd0

…tion/AWSLambdaWrapper.cs Co-authored-by: Christian Neumüller <[email protected]>

Update src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementa…

a5228b9

…tion/AWSLambdaWrapper.cs Co-authored-by: Christian Neumüller <[email protected]>

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

8994534

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

54d7016

utpilla and others added 4 commits August 4, 2022 21:38

Merge branch 'main' into issue/AWS-Lambda-wrapper-and-parent-context

851511c

Added brief changes description to CHANGELOG (open-telemetry#403)

04392cc

Shortened descriptions in CHANGELOG (open-telemetry#403)

cd9ffa8

CHANGELOG entry lines break (open-telemetry#403)

cc51acf

utpilla merged commit ba73fd8 into open-telemetry:main Aug 5, 2022

Oberon00 mentioned this pull request Aug 9, 2022

[Instrumentation.AWSLambda] Updated AWSLambda ActivitySource Name #534

Merged

2 tasks

Oberon00 mentioned this pull request Sep 6, 2022

[Instrumentation.AwsLambda] Enable public API check. #607

Merged

Oberon00 mentioned this pull request Nov 9, 2022

AWS Lambda support for extraction of W3C trace headers sent over http #343

Closed

2 tasks

rypdal mentioned this pull request Jun 1, 2023

REQUEST: New membership for rypdal open-telemetry/community#1518

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AWS Lambda wrapper enhancements: Trace methods enhancements and Activity creation behaviour changes. #408

AWS Lambda wrapper enhancements: Trace methods enhancements and Activity creation behaviour changes. #408

rypdal commented Jun 8, 2022 •

edited

Loading

codecov bot commented Jun 8, 2022 •

edited

Loading

utpilla commented Jul 14, 2022

Oberon00 left a comment

Oberon00 commented Aug 4, 2022

utpilla commented Aug 4, 2022

rypdal commented Aug 5, 2022 •

edited

Loading

utpilla commented Aug 5, 2022

rypdal commented Aug 8, 2022

AWS Lambda wrapper enhancements: Trace methods enhancements and Activity creation behaviour changes. #408

AWS Lambda wrapper enhancements: Trace methods enhancements and Activity creation behaviour changes. #408

Conversation

rypdal commented Jun 8, 2022 • edited Loading

Changes

codecov bot commented Jun 8, 2022 • edited Loading

Codecov Report

utpilla commented Jul 14, 2022

Oberon00 left a comment

Choose a reason for hiding this comment

Oberon00 commented Aug 4, 2022

utpilla commented Aug 4, 2022

rypdal commented Aug 5, 2022 • edited Loading

utpilla commented Aug 5, 2022

rypdal commented Aug 8, 2022

rypdal commented Jun 8, 2022 •

edited

Loading

codecov bot commented Jun 8, 2022 •

edited

Loading

rypdal commented Aug 5, 2022 •

edited

Loading