[Instrumentation.AwsLambda] Enable public API check. #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
commented
Aug 24, 2022
...elemetry.Contrib.Instrumentation.AWSLambda/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
2 tasks
Oberon00
force-pushed
the
feature/awslambda-apicheck
branch
from
7a2eadf to
1ef074b
Compare
Oberon00
commented
Aug 24, 2022
...elemetry.Contrib.Instrumentation.AWSLambda/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 76.70% 76.70%
=======================================
Files 170 170
Lines 5161 5161
=======================================
Hits 3959 3959
Misses 1202 1202
|
utpilla
added
the
comp:instrumentation.awslambda
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Oberon00
force-pushed
the
feature/awslambda-apicheck
branch
from
a7aa258 to
febe06c
Compare
Oberon00
commented
Sep 5, 2022
src/OpenTelemetry.Instrumentation.AWSLambda/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt
Show resolved
Hide resolved
rypdal
approved these changes
Sep 5, 2022
1 task
utpilla
reviewed
Sep 6, 2022
| @@ -5,6 +5,7 @@ | |||
| <Description>AWS Lambda tracing wrapper for OpenTelemetry .NET</Description> | |||
| <PackageTags>$(PackageTags);AWS Lambda</PackageTags> | |||
| <MinVerTagPrefix>Instrumentation.AWSLambda-</MinVerTagPrefix> | |||
| <EnablePublicApi>true</EnablePublicApi> | |||
There was a problem hiding this comment.
You might want to enable code analysis as well.
There was a problem hiding this comment.
That is disabled by default? Weird, how should I know 😅
I will try to enable it.
Maybe it would be better to enable it by default and explicitly disable it in projects where it causes problems?
There was a problem hiding this comment.
I tried it locally, the tool only suggested adding some ConfigureAwait(false) in some places. I will submit a PR for that eventually, but I don't want to hold up the release longer, so I will do that after #590
utpilla
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable public API check for Instrumentation.AwsLambda, as I think that's a very useful tool.
No CHANGELOG entry.