Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda support for extraction of W3C trace headers sent over http #343

Closed
1 of 2 tasks
khpeet opened this issue May 4, 2022 · 8 comments
Closed
1 of 2 tasks
Assignees
Labels
comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda

Comments

@khpeet
Copy link

khpeet commented May 4, 2022

Issue with OpenTelemetry.Contrib.Instrumentation.AWSLambda

List of all OpenTelemetry NuGet
packages
and version that you are
using (e.g. OpenTelemetry 1.0.2):

    <PackageReference Include="OpenTelemetry.Contrib.Instrumentation.AWS" Version="1.0.1" />
    <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.1.0-beta1" />
    <PackageReference Include="OpenTelemetry.Contrib.Instrumentation.AWSLambda" Version="1.1.0-beta1" />
    <PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc8" />

Runtime version (e.g. net462, net48, netcoreapp3.1, net6.0 etc. You can
find this information from the *.csproj file):

netcoreapp3.1

Is this a feature request or a bug?

  • Feature Request
  • Bug

What is the expected behavior?

Incoming http W3C trace headers are extracted and added to the active span created. Currently only headers from X-Ray are extracted according to the comments in this method.

What is the actual behavior?
I am sending traceparent and tracestate headers from a client SPA to an AWS dotnetcore3.1 Lambda using this wrapper. Currently the trace context sent via HTTP headers are not automatically extracted via this wrapper, thus I have reverted to not use this wrapper and am manually creating my own Spans/extraction of context.

@khpeet khpeet added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label May 4, 2022
@khpeet
Copy link
Author

khpeet commented May 5, 2022

@srprash -- @alanwest recommended to tag you

@jmpf2019
Copy link

I'm also experiencing the same issue with a project I'm working with. Hope this can be solved soon.

@srprash
Copy link
Contributor

srprash commented May 12, 2022

Hi @khpeet and @jmpf2019
Thanks for opening this feature request. Adding support for W3C in the AWS Lambda instrumentation is on our backlog, however I cannot provide and ETA for it at the moment. I will provide an update as soon as possible.

@srprash srprash self-assigned this May 12, 2022
@khpeet
Copy link
Author

khpeet commented Jun 28, 2022

hey @srprash - is there any progress on this? Thanks!

@jmpf2019
Copy link

Hi @srprash, same as previous comment ^, checking if there's any progress on this.

@Oberon00
Copy link
Member

Oberon00 commented Nov 9, 2022

@Oberon00
Copy link
Member

Can someone with permissions please close this issue? See my previous comment.

@Kielek
Copy link
Contributor

Kielek commented Jul 19, 2023

Closing per @Oberon00 comment.

@Kielek Kielek closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda
Projects
None yet
Development

No branches or pull requests

5 participants