Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] Fix log message in Meter::RegisterSyncMetricStorage #2325

Merged
merged 4 commits into from
Sep 25, 2023
Merged

[SDK] Fix log message in Meter::RegisterSyncMetricStorage #2325

merged 4 commits into from
Sep 25, 2023

Conversation

ThomsonTan
Copy link
Contributor

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team September 23, 2023 00:15
lalitb
lalitb approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link

codecov bot commented Sep 23, 2023 •
edited
Loading

Codecov Report

Merging #2325 (c49184f) into main (d49ba52) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2325   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         199      199           
  Lines        5997     5997           
=======================================
  Hits         5244     5244           
  Misses        753      753
Files Coverage Δ
sdk/src/metrics/meter.cc 61.45% <0.00%> (ø)

marcalff
marcalff approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@marcalff marcalff merged commit ab83f4f into open-telemetry:main Sep 25, 2023
44 checks passed
@marcalff marcalff changed the title Fix minor inconsistent log message in Meter::RegisterSyncMetricStorage [SDK] Fix log message in Meter::RegisterSyncMetricStorage Oct 11, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalff marcalff marcalff approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomsonTan @lalitb @marcalff