Skip to content

Commit

Permalink
Fix minor inconsistent log message in Meter::RegisterSyncMetricStorage (
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomsonTan authored Sep 25, 2023
1 parent d49ba52 commit ab83f4f
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions sdk/src/metrics/meter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,9 @@ std::unique_ptr<SyncWritableMetricStorage> Meter::RegisterSyncMetricStorage(
auto ctx = meter_context_.lock();
if (!ctx)
{
OTEL_INTERNAL_LOG_ERROR("[Meter::RegisterMetricStorage] - Error during finding matching views."
<< "The metric context is invalid");
OTEL_INTERNAL_LOG_ERROR(
"[Meter::RegisterSyncMetricStorage] - Error during finding matching views."
<< "The metric context is invalid");
return nullptr;
}
auto view_registry = ctx->GetViewRegistry();
Expand Down Expand Up @@ -335,7 +336,7 @@ std::unique_ptr<SyncWritableMetricStorage> Meter::RegisterSyncMetricStorage(
if (!success)
{
OTEL_INTERNAL_LOG_ERROR(
"[Meter::RegisterMetricStorage] - Error during finding matching views."
"[Meter::RegisterSyncMetricStorage] - Error during finding matching views."
<< "Some of the matching view configurations mayn't be used for metric collection");
}
return storages;
Expand Down

1 comment on commit ab83f4f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: ab83f4f Previous: d49ba52 Ratio
BM_LockFreeBuffer/2 3921166.553602114 ns/iter 1891860.008239746 ns/iter 2.07

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.