Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix log message in Meter::RegisterSyncMetricStorage #2325

Merged
merged 4 commits into from
Sep 25, 2023
Merged

[SDK] Fix log message in Meter::RegisterSyncMetricStorage #2325

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fdbe83
Fix inconsistent log message
ThomsonTan Sep 23, 2023
8badb30
Merge branch 'main' into fix-1
lalitb Sep 23, 2023
b034a35
Format
ThomsonTan Sep 25, 2023
c49184f
Merge branch 'main' into fix-1
marcalff Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sdk/src/metrics/meter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,9 @@ std::unique_ptr<SyncWritableMetricStorage> Meter::RegisterSyncMetricStorage(
auto ctx = meter_context_.lock();
if (!ctx)
{
OTEL_INTERNAL_LOG_ERROR("[Meter::RegisterMetricStorage] - Error during finding matching views."
<< "The metric context is invalid");
OTEL_INTERNAL_LOG_ERROR(
"[Meter::RegisterSyncMetricStorage] - Error during finding matching views."
<< "The metric context is invalid");
return nullptr;
}
auto view_registry = ctx->GetViewRegistry();
Expand Down Expand Up @@ -335,7 +336,7 @@ std::unique_ptr<SyncWritableMetricStorage> Meter::RegisterSyncMetricStorage(
if (!success)
{
OTEL_INTERNAL_LOG_ERROR(
"[Meter::RegisterMetricStorage] - Error during finding matching views."
"[Meter::RegisterSyncMetricStorage] - Error during finding matching views."
<< "Some of the matching view configurations mayn't be used for metric collection");
}
return storages;
Expand Down