use json for writing floats as strings

open-telemetry · Mar 1, 2022 · adb62e2 · adb62e2
1 parent 4493a5e
commit adb62e2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/model/pdata/common.go b/model/pdata/common.go
@@ -379,7 +379,8 @@ func (a AttributeValue) AsString() string {
 		return strconv.FormatBool(a.BoolVal())
 
 	case AttributeValueTypeDouble:
-		return strconv.FormatFloat(a.DoubleVal(), 'f', -1, 64)
+		jsonStr, _ := json.Marshal(a.DoubleVal())
+		return string(jsonStr)
 
 	case AttributeValueTypeInt:
 		return strconv.FormatInt(a.IntVal(), 10)

diff --git a/model/pdata/common_test.go b/model/pdata/common_test.go
@@ -957,6 +957,11 @@ func TestAsString(t *testing.T) {
 			input:    NewAttributeValueDouble(1.61803399),
 			expected: "1.61803399",
 		},
+		{
+			name:     "small float64",
+			input:    NewAttributeValueDouble(.000000009),
+			expected: "9e-9",
+		},
 		{
 			name:     "boolean",
 			input:    NewAttributeValueBool(true),