[windowsservicereceiver] Initial implementation by merdzikdominik · Pull Request #42545 · open-telemetry/opentelemetry-collector-contrib

merdzikdominik · 2025-09-07T22:18:57Z

Fully working windowsservicereceiver.

Performed testing by running:

make test
make lint

linux-foundation-easycla · 2025-09-07T22:19:05Z

The committers listed above are authorized under a signed CLA.

✅ login: pjanotti / name: Paulo Janotti (4399e54)

github-actions · 2025-09-07T22:19:09Z

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

Please review our Contributing Guidelines.
Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

shalper2 · 2025-09-08T16:39:54Z

Het @merdzikdominik thanks for taking a look at this issue and contributing to it! Could you please include tests for the code that you are contributing?

pjanotti

Thanks for working on this @merdzikdominik!

pjanotti · 2025-09-09T04:07:27Z

 // SPDX-License-Identifier: Apache-2.0

-//revive:disable:unused-parameter
+//go:build windows


Since there is a file named factory_windows.go this file, factory.go, is expected to have code that is common to all platforms and this file should not need this compile directive.

This directive shouldn't be necessary anymore... I see that it is still needed because there is still a NewFactory implementation in factory_others.go...

pjanotti · 2025-09-09T04:11:57Z

+	)
+}
+
+func createDefaultConfig() component.Config {


This same function is also defined in factory.go so there is no need to have it here, as long as the compile directive //go:build windows is removed from factory.go.

Side note: the suffix of the file names in go, e.g.: factory_windows.go, is in general enough for the compiler, but I personally like to have the compile directives there too.

This is still an issue.

pjanotti · 2025-09-09T04:23:17Z

+
+var errUnsupportedOS = errors.New("windowsservicereceiver: supported only on Windows")
+
+func NewFactory() receiver.Factory {


At first I think this will be better if you have the same NewFactory at factory.go but then changing line 26 to receiver.WithMetrics(createMetricsReceiver, metadata.MetricsStability) and then implement the platform dependent createMetricsReceiver in factory_windows.go and factory_others.go. See receiver/windowsperfcountersreceiver for an example.

pjanotti · 2025-09-09T04:37:25Z

+			continue
+		}
+
+		val := int64(mapStateToMetricValue(State(svc.status.State)))


Isn't possible to cast directly from svc.status.State?

atoulme · 2025-09-17T05:53:14Z

Please follow https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md for new components - please create and link an issue here.

replaced "get" prefixes with "update" for method names accordingly to their logic

(1) Errors are collected and returned collectively at the end (errsCh channel + multierr.Append). (2) Scrape is parallel (errgroup + concurrency-limiting semaphore). (3) Status is cast directly from svc.status.State with range validation. (4) Removed an unnecessary, unused bool from mapStartTypeToAttr; start has a clean signature. (5) Method names indicate the mutation: updateService, updateStatus, updateConfig.

…tor-contrib into merdzikdominik-windowsservicereceiver

github-actions · 2025-10-13T21:37:28Z

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

Please review our Contributing Guidelines.
Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

pjanotti

If we get the file organization and API cleaned up I think we can move ahead. The next steps will be to:

Add an integration test (select a server running on GH runners and check that we get the expected metrics)
Refactor serviceManager (likely remove it) so we can directly use the mgr.Mgr (see comment)

pjanotti · 2025-10-10T20:34:38Z

 // SPDX-License-Identifier: Apache-2.0

-//revive:disable:unused-parameter
+//go:build windows


This directive shouldn't be necessary anymore... I see that it is still needed because there is still a NewFactory implementation in factory_others.go...

pjanotti · 2025-10-13T22:12:04Z

@merdzikdominik Please, review the comments.

github-actions · 2025-10-28T05:21:21Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

…nik-windowsservicereceiver-codereview2

…cereceiver-codereview2 Merdzikdominik windowsservicereceiver codereview2

…tor-contrib into merdzikdominik-windowsservicereceiver

github-actions · 2025-11-03T23:03:20Z

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

Please review our Contributing Guidelines.
Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

otelbot · 2025-11-04T02:47:51Z

Thank you for your contribution @merdzikdominik! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

Fully working windowsservicereceiver. Performed testing by running: - make test - make lint --------- Co-authored-by: Paulo Janotti <pjanotti@splunk.com>

merdzikdominik added 9 commits September 7, 2025 23:22

Add files via upload

d700d32

Update factory_windows.go

9b32801

Update factory.go

2caf6a8

Update scraper.go

e92563e

Update winapi.go

e8d7715

Update winservice.go

4193646

Update README.md

8ec62cc

Update README.md

e4ce831

Update builder-config.yaml

e074798

merdzikdominik requested review from a team and pjanotti as code owners September 7, 2025 22:18

github-actions Bot assigned atoulme Sep 7, 2025

github-actions Bot added the first-time contributor PRs made by new contributors label Sep 7, 2025

github-actions Bot added receiver/windowsservice cmd/otelcontribcol otelcontribcol command labels Sep 7, 2025

github-actions Bot requested a review from shalper2 September 7, 2025 22:19

shalper2 reviewed Sep 8, 2025

View reviewed changes

Comment thread receiver/windowsservicereceiver/README.md Outdated

Comment thread receiver/windowsservicereceiver/README.md Outdated

shalper2 reviewed Sep 8, 2025

View reviewed changes

Comment thread receiver/windowsservicereceiver/scraper.go Outdated

shalper2 reviewed Sep 8, 2025

View reviewed changes

Comment thread receiver/windowsservicereceiver/scraper.go

pjanotti reviewed Sep 9, 2025

View reviewed changes

pjanotti mentioned this pull request Sep 16, 2025

Implement Windows Service Receiver #38619

Open

4 tasks

atoulme added the Sponsor Needed New component seeking sponsor label Sep 17, 2025

atoulme marked this pull request as draft September 17, 2025 05:53

merdzikdominik added 3 commits September 21, 2025 12:39

Update winservice.go

314ac81

replaced "get" prefixes with "update" for method names accordingly to their logic

pjanotti added 2 commits October 13, 2025 13:51

Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…

f655c70

…tor-contrib into merdzikdominik-windowsservicereceiver

Undo changes to builder-config.yaml

91fc456

pjanotti added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 13, 2025

pjanotti reviewed Oct 13, 2025

View reviewed changes

github-actions Bot added the Stale label Oct 28, 2025

merdzikdominik added 4 commits October 29, 2025 19:05

codereview2

1231141

builder-config.yaml fr

27f9ba9

Merge branch 'merdzikdominik-windowsservicereceiver' into merdzikdomi…

0876798

…nik-windowsservicereceiver-codereview2

Merge pull request #2 from merdzikdominik/merdzikdominik-windowsservi…

9d28ac4

…cereceiver-codereview2 Merdzikdominik windowsservicereceiver codereview2

github-actions Bot removed the Stale label Oct 30, 2025

pjanotti added 2 commits November 3, 2025 14:52

Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…

654c1ef

…tor-contrib into merdzikdominik-windowsservicereceiver

make tidy

4de59c3

pjanotti removed the Sponsor Needed New component seeking sponsor label Nov 3, 2025

pjanotti marked this pull request as ready for review November 3, 2025 23:02

github-actions Bot assigned mwear Nov 3, 2025

pjanotti added the Run Windows Enable running windows test on a PR label Nov 3, 2025

Remove changes to build-config.yaml

5c857a0

pjanotti changed the title ~~Pull request for windowsservice receiver~~ [windowsservicereceiver] Initial implementation Nov 3, 2025

pjanotti added 2 commits November 3, 2025 15:58

make generate

2c77f18

Merge branch 'main' into merdzikdominik-windowsservicereceiver

4399e54

atoulme approved these changes Nov 4, 2025

View reviewed changes

atoulme merged commit ac173bc into open-telemetry:main Nov 4, 2025
225 checks passed

github-actions Bot added this to the next release milestone Nov 4, 2025


		var errUnsupportedOS = errors.New("windowsservicereceiver: supported only on Windows")

		func NewFactory() receiver.Factory {

Conversation

merdzikdominik commented Sep 7, 2025

Uh oh!

linux-foundation-easycla Bot commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 7, 2025

Uh oh!

Uh oh!

Uh oh!

shalper2 commented Sep 8, 2025

Uh oh!

Uh oh!

Uh oh!

pjanotti left a comment

Choose a reason for hiding this comment

Uh oh!

pjanotti Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

pjanotti Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pjanotti Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

pjanotti Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pjanotti Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pjanotti Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

atoulme commented Sep 17, 2025

Uh oh!

github-actions Bot commented Oct 13, 2025

Uh oh!

pjanotti left a comment

Choose a reason for hiding this comment

Uh oh!

pjanotti Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pjanotti commented Oct 13, 2025

Uh oh!

github-actions Bot commented Oct 28, 2025

Uh oh!

github-actions Bot commented Nov 3, 2025

Uh oh!

Uh oh!

otelbot Bot commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

linux-foundation-easycla Bot commented Sep 7, 2025 •

edited

Loading