Merdzikdominik windowsservicereceiver codereview2#2
Merged
merdzikdominik merged 3 commits intoOct 29, 2025
Conversation
…nik-windowsservicereceiver-codereview2
merdzikdominik
merged commit 9d28ac4
into
merdzikdominik-windowsservicereceiver
15 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collecting errors and emitting them at the end – in scraper.go we use multierr.Append, and emit metrics normally.
Without goroutines – the loop is synchronous (as suggested by "keep it simple for now").
Direct cast – val := int64(svc.status.State).
No unnecessary bool param – mapStartTypeToAttr(st StartType).
UpdateStatus/updateConfig naming – changed and used.
Nits and cleanups – added a blank line before //go:build !windows, factory.go without unnecessary directives, in winapi.go h -> svcmgr, ConfigEx -> configEx.