Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
d700d32
Add files via upload
merdzikdominik Sep 7, 2025
9b32801
Update factory_windows.go
merdzikdominik Sep 7, 2025
2caf6a8
Update factory.go
merdzikdominik Sep 7, 2025
e92563e
Update scraper.go
merdzikdominik Sep 7, 2025
e8d7715
Update winapi.go
merdzikdominik Sep 7, 2025
4193646
Update winservice.go
merdzikdominik Sep 7, 2025
8ec62cc
Update README.md
merdzikdominik Sep 7, 2025
e4ce831
Update README.md
merdzikdominik Sep 7, 2025
e074798
Update builder-config.yaml
merdzikdominik Sep 7, 2025
314ac81
Update winservice.go
merdzikdominik Sep 21, 2025
72fb072
Update scraper.go
merdzikdominik Sep 21, 2025
203dc1c
Update factory_windows.go
merdzikdominik Sep 21, 2025
00e60bc
Update factory_others.go
merdzikdominik Sep 21, 2025
b5341a6
Update factory.go
merdzikdominik Sep 21, 2025
3af4ef6
Update README.md
merdzikdominik Sep 21, 2025
8f5bce0
Update README.md
merdzikdominik Sep 21, 2025
4708906
Update go.mod
merdzikdominik Sep 21, 2025
b689b9c
Update go.sum
merdzikdominik Sep 21, 2025
c7bb867
Update factory.go
merdzikdominik Sep 22, 2025
927b023
Update factory_others.go
merdzikdominik Sep 22, 2025
448d532
Update scraper.go
merdzikdominik Sep 22, 2025
f516436
Update winapi.go
merdzikdominik Sep 22, 2025
35f02a7
Update winservice.go
merdzikdominik Sep 22, 2025
1ddaabe
removed goroutine from scraper.go
merdzikdominik Oct 9, 2025
57d15ee
adjusted builder-config.yaml
merdzikdominik Oct 10, 2025
bdb4484
Merge pull request #1 from merdzikdominik/merdzikdominik-windowsservi…
merdzikdominik Oct 10, 2025
f655c70
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
pjanotti Oct 13, 2025
91fc456
Undo changes to builder-config.yaml
pjanotti Oct 13, 2025
1231141
codereview2
merdzikdominik Oct 29, 2025
27f9ba9
builder-config.yaml fr
merdzikdominik Oct 29, 2025
0876798
Merge branch 'merdzikdominik-windowsservicereceiver' into merdzikdomi…
merdzikdominik Oct 29, 2025
9d28ac4
Merge pull request #2 from merdzikdominik/merdzikdominik-windowsservi…
merdzikdominik Oct 29, 2025
654c1ef
Merge branch 'main' of github.com:open-telemetry/opentelemetry-collec…
pjanotti Nov 3, 2025
4de59c3
make tidy
pjanotti Nov 3, 2025
5c857a0
Remove changes to build-config.yaml
pjanotti Nov 3, 2025
2c77f18
make generate
pjanotti Nov 3, 2025
4399e54
Merge branch 'main' into merdzikdominik-windowsservicereceiver
pjanotti Nov 4, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 11 additions & 31 deletions receiver/windowsservicereceiver/factory.go
Original file line number Diff line number Diff line change
@@ -1,24 +1,18 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

//revive:disable:unused-parameter

package windowsservicereceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsservicereceiver"

import (
"context"
"time"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/consumer"
"go.opentelemetry.io/collector/receiver"
"go.opentelemetry.io/collector/scraper/scraperhelper"

"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsservicereceiver/internal/metadata"
)

func createDefaultConfig() component.Config {
return &Config{}
}

func NewFactory() receiver.Factory {
return receiver.NewFactory(
metadata.Type,
Expand All @@ -27,27 +21,13 @@ func NewFactory() receiver.Factory {
)
}

func createMetricsReceiver(
_ context.Context,
_ receiver.Settings,
rConf component.Config,
consumer consumer.Metrics,
) (receiver.Metrics, error) {
cfg := rConf.(*Config)
rcvr := newMetricsReceiver(cfg, consumer)
return rcvr, nil
}

func newMetricsReceiver(*Config, consumer.Metrics) *windowsServiceReceiver {
return &windowsServiceReceiver{}
}

type windowsServiceReceiver struct{}

func (*windowsServiceReceiver) Start(context.Context, component.Host) error {
return nil
}

func (*windowsServiceReceiver) Shutdown(context.Context) error {
return nil
func createDefaultConfig() component.Config {
return &Config{
ControllerConfig: scraperhelper.ControllerConfig{
CollectionInterval: 1 * time.Minute,
},
MetricsBuilderConfig: metadata.DefaultMetricsBuilderConfig(),
IncludeServices: nil,
ExcludeServices: nil,
}
}
26 changes: 26 additions & 0 deletions receiver/windowsservicereceiver/factory_others.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

//go:build !windows
Comment thread
pjanotti marked this conversation as resolved.

package windowsservicereceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsservicereceiver"

import (
"context"
"errors"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/consumer"
"go.opentelemetry.io/collector/receiver"
)

var errUnsupportedOS = errors.New("windowsservicereceiver: supported only on Windows")

func createMetricsReceiver(
_ context.Context,
_ receiver.Settings,
_ component.Config,
_ consumer.Metrics,
) (receiver.Metrics, error) {
return nil, errUnsupportedOS
}
40 changes: 40 additions & 0 deletions receiver/windowsservicereceiver/factory_windows.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,45 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

//go:build windows

package windowsservicereceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsservicereceiver"

import (
"context"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/consumer"
"go.opentelemetry.io/collector/receiver"
"go.opentelemetry.io/collector/scraper"
"go.opentelemetry.io/collector/scraper/scraperhelper"

"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsservicereceiver/internal/metadata"
)

func createMetricsReceiver(
_ context.Context,
settings receiver.Settings,
cfg component.Config,
next consumer.Metrics,
) (receiver.Metrics, error) {
rcfg := cfg.(*Config)
mb := metadata.NewMetricsBuilder(rcfg.MetricsBuilderConfig, settings)
s := newWindowsServiceScraper(settings, rcfg, mb)

ms, err := scraper.NewMetrics(
s.scrape,
scraper.WithStart(s.start),
scraper.WithShutdown(s.shutdown),
)
if err != nil {
return nil, err
}

return scraperhelper.NewMetricsController(
&rcfg.ControllerConfig,
settings,
next,
scraperhelper.AddScraper(metadata.Type, ms),
)
}
4 changes: 2 additions & 2 deletions receiver/windowsservicereceiver/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ require (
go.opentelemetry.io/collector/pdata v1.45.0
go.opentelemetry.io/collector/receiver v1.45.0
go.opentelemetry.io/collector/receiver/receivertest v0.139.0
go.opentelemetry.io/collector/scraper v0.139.0
go.opentelemetry.io/collector/scraper/scraperhelper v0.139.0
go.uber.org/goleak v1.3.0
go.uber.org/multierr v1.11.0
go.uber.org/zap v1.27.0
golang.org/x/sys v0.36.0
)
Expand Down Expand Up @@ -44,13 +46,11 @@ require (
go.opentelemetry.io/collector/pipeline v1.45.0 // indirect
go.opentelemetry.io/collector/receiver/receiverhelper v0.139.0 // indirect
go.opentelemetry.io/collector/receiver/xreceiver v0.139.0 // indirect
go.opentelemetry.io/collector/scraper v0.139.0 // indirect
go.opentelemetry.io/otel v1.38.0 // indirect
go.opentelemetry.io/otel/metric v1.38.0 // indirect
go.opentelemetry.io/otel/sdk v1.38.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.38.0 // indirect
go.opentelemetry.io/otel/trace v1.38.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
go.yaml.in/yaml/v3 v3.0.4 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250804133106-a7a43d27e69b // indirect
google.golang.org/grpc v1.76.0 // indirect
Expand Down
142 changes: 123 additions & 19 deletions receiver/windowsservicereceiver/scraper.go
Original file line number Diff line number Diff line change
@@ -1,48 +1,152 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

//revive:disable:unused-parameter
//go:build windows

package windowsservicereceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsservicereceiver"

import (
"context"
"errors"
"time"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/pdata/pmetric"
"go.opentelemetry.io/collector/receiver"
"go.uber.org/multierr"
"go.uber.org/zap"
"golang.org/x/sys/windows"

"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/windowsservicereceiver/internal/metadata"
)

//nolint:unused
type windowsServiceScraper struct {
scm serviceManager
settings receiver.Settings
conf *Config
mb *metadata.MetricsBuilder
logger *zap.Logger
cfg *Config
mb *metadata.MetricsBuilder
mgr serviceManager
includeSet map[string]struct{}
excludeSet map[string]struct{}

disabled bool
}

//nolint:unused
func newWindowsServiceScraper(settings receiver.Settings, _ *Config) windowsServiceScraper {
return windowsServiceScraper{
settings: settings,
mb: metadata.NewMetricsBuilder(metadata.DefaultMetricsBuilderConfig(), settings),
func newWindowsServiceScraper(settings receiver.Settings, cfg *Config, mb *metadata.MetricsBuilder) *windowsServiceScraper {
ws := &windowsServiceScraper{
logger: settings.Logger,
cfg: cfg,
mb: mb,
mgr: serviceManager{},
}
if len(cfg.IncludeServices) > 0 {
ws.includeSet = make(map[string]struct{}, len(cfg.IncludeServices))
for _, n := range cfg.IncludeServices {
ws.includeSet[n] = struct{}{}
}
}
if len(cfg.ExcludeServices) > 0 {
ws.excludeSet = make(map[string]struct{}, len(cfg.ExcludeServices))
for _, n := range cfg.ExcludeServices {
ws.excludeSet[n] = struct{}{}
}
}
return ws
}

//nolint:unused
func (*windowsServiceScraper) start(context.Context, component.Host) (err error) {
return nil
func mapStartTypeToAttr(st StartType) metadata.AttributeStartupMode {
switch st {
case StartBoot:
return metadata.AttributeStartupModeBootStart
case StartSystem:
return metadata.AttributeStartupModeSystemStart
case StartAutomatic:
return metadata.AttributeStartupModeAutoStart
case StartManual:
return metadata.AttributeStartupModeDemandStart
case StartDisabled:
return metadata.AttributeStartupModeDisabled
default:
return metadata.AttributeStartupModeDemandStart
}
}

//nolint:unused
func (*windowsServiceScraper) shutdown(context.Context) (err error) {
func (ws *windowsServiceScraper) start(_ context.Context, _ component.Host) error {
if err := ws.mgr.connect(); err != nil {
if errors.Is(err, windows.ERROR_ACCESS_DENIED) {
ws.logger.Warn("windowsservicereceiver: access denied to Service Control Manager; metrics will not be collected", zap.Error(err))
ws.disabled = true
return nil
}
return err
}
return nil
}

//nolint:unused
func (ws *windowsServiceScraper) scrape(context.Context) (pmetric.Metrics, error) {
return ws.mb.Emit(), nil
func (ws *windowsServiceScraper) shutdown(_ context.Context) error {
if ws.disabled {
return nil
}
return ws.mgr.disconnect()
}

func (ws *windowsServiceScraper) allowed(name string) bool {
if len(ws.includeSet) > 0 {
if _, ok := ws.includeSet[name]; !ok {
return false
}
}
if _, banned := ws.excludeSet[name]; banned {
return false
}
return true
}

func (ws *windowsServiceScraper) scrape(_ context.Context) (pmetric.Metrics, error) {
if ws.disabled {
return ws.mb.Emit(), nil
}

ts := pcommon.NewTimestampFromTime(time.Now())

names, err := ws.mgr.listServices()
if err != nil {
return ws.mb.Emit(), err
}

var scrapeErr error

for _, name := range names {
Comment thread
atoulme marked this conversation as resolved.
if !ws.allowed(name) {
continue
}

svc, err := updateService(&ws.mgr, name)
if err != nil {
scrapeErr = multierr.Append(scrapeErr, err)
continue
}

if err := svc.updateStatus(); err != nil {
_ = svc.close()
scrapeErr = multierr.Append(scrapeErr, err)
continue
}
if err := svc.updateConfig(); err != nil {
_ = svc.close()
scrapeErr = multierr.Append(scrapeErr, err)
continue
}

val := int64(svc.status.State)
startAttr := mapStartTypeToAttr(svc.config.StartType)

ws.mb.RecordWindowsServiceStatusDataPoint(ts, val, name, startAttr)

if err := svc.close(); err != nil {
scrapeErr = multierr.Append(scrapeErr, err)
}
}

return ws.mb.Emit(), scrapeErr
}
Loading