Add step that generate issues based on JUnit test results#38270
Conversation
|
Weird, I don't even see the issuegenerator logs here 🤔 |
afbe556 to
7111659
Compare
|
@mx-psi, I just wanted to let you know that I believe I'll need to patch As seen in this workflow run, It is writing open-telemetry twice in the URL. See the difference by clicking:
The reason behind this is that the ENV variable Issuegenerator is building this API call by concatenating the ENV variables, |
|
Opened open-telemetry/opentelemetry-go-build-tools#719 to address the problem |
To unblock #38270 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
fb0eac8 to
f3ced85
Compare
|
@mx-psi @songy23 looking at the current error: Could this be a misconfiguration in the repo settings? I'm suggesting that based on the discussion https://github.com/orgs/community/discussions/60820#discussioncomment-6445895 |
|
@ArthurSens Can you file an issue over at https://github.com/open-telemetry/community to ask for this? Only the admins group has permission to see this I think, and we are not part of it |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
d6a7df7 to
0c72b34
Compare
|
PR cleaned up and ready for merge. Latest test failed due to lack of permissions: Our understanding is that those permissions will only be granted once running from the main branch A commit with a failing test is still there, so we can quickly test the automation once it's merged. We should see an open issue right away. I can also remove the commit if folks prefer :) |
|
@ArthurSens would you please open a separate PR removing the test? Then we can merge both PRs one after the other. |
|
Yes, but can we do it beginning of next week? I'm on holidays until Tuesday |
0c72b34 to
05859da
Compare
mx-psi
left a comment
There was a problem hiding this comment.
Discussed offline, since it may be that the 403 error is due to this running on a fork, we are going to merge this and check if it works on main.
To unblock open-telemetry#38270 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
#### Description While working on #38270, I accidently disabled all tests for the go version 1.24. Here I'm fixing the problem and also updating comments to make the conditionals easier to understand. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes #39618 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
#### Description In #38270, I've introduced a workflow to create new issues when tests fail on main. Somehow, that change caused an unexpected behavior with test result reports, as explained in #39616. To be completely transparent, I'm unsure if this PR fixes the issue. Following what is [documented by GitHub](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#steps-context), the existing configuration should work... but, well, it isn't. So I'm trying the opposite of what the documentation says. I would really appreciate it if someone with GitHub Actions experience could chime in and guide me because I'm taking shots in the dark at this point 😕 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
#### Description In open-telemetry#38270, I've introduced a workflow to create new issues when tests fail on main. Somehow, that change caused an unexpected behavior with test result reports, as explained in open-telemetry#39616. To be completely transparent, I'm unsure if this PR fixes the issue. Following what is [documented by GitHub](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#steps-context), the existing configuration should work... but, well, it isn't. So I'm trying the opposite of what the documentation says. I would really appreciate it if someone with GitHub Actions experience could chime in and guide me because I'm taking shots in the dark at this point 😕 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
#### Description In open-telemetry#38270, I've introduced a workflow to create new issues when tests fail on main. Somehow, that change caused an unexpected behavior with test result reports, as explained in open-telemetry#39616. To be completely transparent, I'm unsure if this PR fixes the issue. Following what is [documented by GitHub](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#steps-context), the existing configuration should work... but, well, it isn't. So I'm trying the opposite of what the documentation says. I would really appreciate it if someone with GitHub Actions experience could chime in and guide me because I'm taking shots in the dark at this point 😕 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Description
Now that we're uploading files correctly (#38236), this PR extends the current unit test workflow to download the artifacts and calling issuegenerator to create the issues.
Link to tracking issue
Related to #36761