Fail workflow when conclusion is failure#39805
Merged
Merged
Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Contributor
|
When do you want to try this out? |
Member
Author
|
Whenever is best for someone with permissions to merge/revert :) I can make time during weekdays |
mx-psi
approved these changes
May 9, 2025
mx-psi
added a commit
that referenced
this pull request
May 9, 2025
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
#### Description In open-telemetry#38270, I've introduced a workflow to create new issues when tests fail on main. Somehow, that change caused an unexpected behavior with test result reports, as explained in open-telemetry#39616. To be completely transparent, I'm unsure if this PR fixes the issue. Following what is [documented by GitHub](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#steps-context), the existing configuration should work... but, well, it isn't. So I'm trying the opposite of what the documentation says. I would really appreciate it if someone with GitHub Actions experience could chime in and guide me because I'm taking shots in the dark at this point 😕 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
Reverts open-telemetry#39805 Based on open-telemetry#39967 it did not work
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
#### Description In open-telemetry#38270, I've introduced a workflow to create new issues when tests fail on main. Somehow, that change caused an unexpected behavior with test result reports, as explained in open-telemetry#39616. To be completely transparent, I'm unsure if this PR fixes the issue. Following what is [documented by GitHub](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#steps-context), the existing configuration should work... but, well, it isn't. So I'm trying the opposite of what the documentation says. I would really appreciate it if someone with GitHub Actions experience could chime in and guide me because I'm taking shots in the dark at this point 😕 Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
Reverts open-telemetry#39805 Based on open-telemetry#39967 it did not work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #38270, I've introduced a workflow to create new issues when tests fail on main. Somehow, that change caused an unexpected behavior with test result reports, as explained in #39616.
To be completely transparent, I'm unsure if this PR fixes the issue. Following what is documented by GitHub, the existing configuration should work... but, well, it isn't. So I'm trying the opposite of what the documentation says.
I would really appreciate it if someone with GitHub Actions experience could chime in and guide me because I'm taking shots in the dark at this point 😕