Skip to content

Fix duplicated owner when calling GitHub APIs#720

Merged
mx-psi merged 4 commits into
open-telemetry:mainfrom
ArthurSens:patch-issuegenerator
Mar 13, 2025
Merged

Fix duplicated owner when calling GitHub APIs#720
mx-psi merged 4 commits into
open-telemetry:mainfrom
ArthurSens:patch-issuegenerator

Conversation

@ArthurSens
Copy link
Copy Markdown
Member

While working on enabling issuegenerator for the collector-contrib repo(open-telemetry/opentelemetry-collector-contrib#38270), I realized we were duplicating the github owner when calling GitHub APIs.

After rereading the docs, I realized that the environment variable GITHUB_REPOSITORY already holds the owner information instead of just the repository information. This PR adjusts the usage of those environment variables, making sure we don't duplicate the owner when calling GitHub APIs.

Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.26%. Comparing base (b62c325) to head (3f3f15d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
issuegenerator/main.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   52.32%   52.26%   -0.06%     
==========================================
  Files          59       59              
  Lines        3524     3528       +4     
==========================================
  Hits         1844     1844              
- Misses       1501     1505       +4     
  Partials      179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi merged commit eecedb1 into open-telemetry:main Mar 13, 2025
@ArthurSens ArthurSens deleted the patch-issuegenerator branch March 13, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants