elasticsearchexporter: refactor encoding; drop metrics support from raw/none/bodymap mapping modes#37928
Merged
andrzej-stencel merged 3 commits intoFeb 21, 2025
Conversation
axw
force-pushed
the
elasticsearchexporter-refactor-encoder
branch
4 times, most recently
from
3a98f3d to
b2b6139
Compare
axw
changed the title
Remove mappingModel, replace with "encoder" interface with mapping mode-specific implementations. Drop support for encoding metrics from "none", "raw", and "bodymap" mapping modes - I don't think their support was intentional. (More refactoring related to open-telemetry#36092)
axw
force-pushed
the
elasticsearchexporter-refactor-encoder
branch
from
b2b6139 to
5a34d72
Compare
carsonip
reviewed
Feb 19, 2025
Contributor
carsonip
left a comment
carsonip
left a comment
There was a problem hiding this comment.
thanks for cleaning up the mess! code lgtm. Looks like a good opportunity to update the README to clarify what signals are supported under which mode. Do you mind doing that?
... and add a table showing supported signals to each.
Contributor
Author
|
@carsonip done, PTAL |
carsonip
approved these changes
Feb 20, 2025
andrzej-stencel
approved these changes
Feb 21, 2025
| [OpenTelemetry Semantic Conventions][SemConv] (version 1.22.0) to [Elastic Common Schema][ECS] where possible. | ||
| This mode may be used for compatibility with existing dashboards that work with ECS. | ||
|
|
||
| | Signal | `ecs` | |
Member
There was a problem hiding this comment.
Maybe consolidating these separate tables into a single table could help? This could be done as a follow-up pull request.
Contributor
Author
There was a problem hiding this comment.
Yeah maybe, I was on the fence - I started doing it in a single table and ended up splitting it when I added new sections. I don't have a strong opinion. WDYT @carsonip?
Contributor
There was a problem hiding this comment.
looks fine to me now. We can refactor the docs later, especially when we start documenting OTel field mapping
yiquanzhou
added a commit
to dash0hq/opentelemetry-collector-contrib
that referenced
this pull request
Feb 24, 2025
* main: (55 commits) [chore] Update core dependencies (open-telemetry#38124) Add kafka topics observer implementation (open-telemetry#38060) [exporter/splunk_hec] Mute errors from draining the response body (open-telemetry#38118) [chore] [exporter/splunk_hec] Remove dead code (open-telemetry#38113) Add support for JUnit test results (open-telemetry#37941) [chore] amend changelog for prometheus receiver change (open-telemetry#38109) [chore] Fix dead links in issue-triaging.md (open-telemetry#38105) [chore] fix deprecation (open-telemetry#38107) [exporter/coralogix] Add new batch options to Coralogix exporter (open-telemetry#38082) [chore][exporter/datadog] fix integration test (open-telemetry#38091) [chore] Update otel to unblock contrib test in core repo (open-telemetry#38100) [chore] Bump go-version match to 1.23 (open-telemetry#38099) [exporter/elasticsearch] Add _metric_names_hash to avoid metric rejections (open-telemetry#37511) elasticsearchexporter: refactor encoding; drop metrics support from raw/none/bodymap mapping modes (open-telemetry#37928) [exporter/stefexporter] Fix incorrectly implemented STEF exporter zstd compression option (open-telemetry#38089) [exporter/clickhouse] Add client info for identifying exporter in `system.query_log` (open-telemetry#37146) [chore] Prepare release 0.120.1 (open-telemetry#38055) [extension/httpforwarder] Shutdown should wait server exit (open-telemetry#37735) receiver/prometheusremotewrite: Add two fields timestamp and value. (open-telemetry#37895) [reciver/sqlqueryreceiver] Add support for SapASE (sybase) (open-telemetry#37773) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
mappingModel, replace withencoderinterface with mapping mode-specific implementations. Drop support for encoding metrics from "none", "raw", and "bodymap" mapping modes - I don't think their support was intentional.Link to tracking issue
More refactoring related to #36092
Testing
Unit tests added. Non-functional change, except that none/raw/bodymap can no longer handle metrics.
Documentation
N/A