Skip to content

[reciver/sqlqueryreceiver] Add support for SapASE (sybase)#37773

Merged
songy23 merged 4 commits into
open-telemetry:mainfrom
Grandys:support-sybase-connections
Feb 20, 2025
Merged

[reciver/sqlqueryreceiver] Add support for SapASE (sybase)#37773
songy23 merged 4 commits into
open-telemetry:mainfrom
Grandys:support-sybase-connections

Conversation

@Grandys
Copy link
Copy Markdown
Contributor

@Grandys Grandys commented Feb 7, 2025

Description

Adding a feature - support for SapASE (Sybase) database connections with thda/tds driver

Link to tracking issue

#36328

Testing

Integration test for SapASE with datagrip/sybase:16.0 for:

  • Tracking processed logs with and without storage
  • Metrics

Documentation

  • Added driver option
  • Added example connection strings for various drivers

@Grandys Grandys requested review from a team, crobert-1 and dmitryax as code owners February 7, 2025 14:50
@github-actions github-actions Bot requested a review from StefanKurek February 7, 2025 18:36
@Grandys Grandys changed the title [reciver/sqlqueryreceiver] Add support for SapASE (sybase) #36328 [reciver/sqlqueryreceiver] Add support for SapASE (sybase) Feb 7, 2025
Comment thread receiver/sqlqueryreceiver/README.md
Comment thread .chloggen/feat-sqlqueryreciver-sap-ase.yaml Outdated
Comment thread receiver/sqlqueryreceiver/integration_test.go
@Grandys Grandys requested a review from crobert-1 February 12, 2025 15:11
@crobert-1
Copy link
Copy Markdown
Member

check-link is failing on link that was already in the README, and the link still works for me. I say we just let it go, and if it keeps failing we can add it to an exclusion list since it's a CI check failure, not an actual dead link.

Copy link
Copy Markdown
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Grandys!

Copy link
Copy Markdown
Contributor

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

@Grandys
Copy link
Copy Markdown
Contributor Author

Grandys commented Feb 19, 2025

@crobert-1 do we wait for another approval from the mainterners? Or we're fine to mark this PR as ready?

@crobert-1 crobert-1 added ready to merge Code review completed; ready to merge by maintainers and removed ready to merge Code review completed; ready to merge by maintainers labels Feb 19, 2025
@crobert-1
Copy link
Copy Markdown
Member

Once conflicts are fixed I can add the label 👍

@dehaansa dehaansa added the ready to merge Code review completed; ready to merge by maintainers label Feb 20, 2025
@songy23 songy23 merged commit 57892ad into open-telemetry:main Feb 20, 2025
@github-actions github-actions Bot added this to the next release milestone Feb 20, 2025
@Grandys Grandys deleted the support-sybase-connections branch February 23, 2025 09:20
yiquanzhou added a commit to dash0hq/opentelemetry-collector-contrib that referenced this pull request Feb 24, 2025
* main: (55 commits)
  [chore] Update core dependencies (open-telemetry#38124)
  Add kafka topics observer implementation (open-telemetry#38060)
  [exporter/splunk_hec] Mute errors from draining the response body (open-telemetry#38118)
  [chore] [exporter/splunk_hec] Remove dead code (open-telemetry#38113)
  Add support for JUnit test results (open-telemetry#37941)
  [chore] amend changelog for prometheus receiver change (open-telemetry#38109)
  [chore] Fix dead links in issue-triaging.md (open-telemetry#38105)
  [chore] fix deprecation (open-telemetry#38107)
  [exporter/coralogix] Add new batch options to Coralogix exporter (open-telemetry#38082)
  [chore][exporter/datadog] fix integration test (open-telemetry#38091)
  [chore] Update otel to unblock contrib test in core repo (open-telemetry#38100)
  [chore] Bump go-version match to 1.23 (open-telemetry#38099)
  [exporter/elasticsearch] Add _metric_names_hash to avoid metric rejections (open-telemetry#37511)
  elasticsearchexporter: refactor encoding; drop metrics support from raw/none/bodymap mapping modes (open-telemetry#37928)
  [exporter/stefexporter] Fix incorrectly implemented STEF exporter zstd compression option (open-telemetry#38089)
  [exporter/clickhouse] Add client info for identifying exporter in `system.query_log` (open-telemetry#37146)
  [chore] Prepare release 0.120.1 (open-telemetry#38055)
  [extension/httpforwarder] Shutdown should wait server exit (open-telemetry#37735)
  receiver/prometheusremotewrite: Add two fields timestamp and value. (open-telemetry#37895)
  [reciver/sqlqueryreceiver] Add support for SapASE (sybase) (open-telemetry#37773)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal/sqlquery ready to merge Code review completed; ready to merge by maintainers receiver/sqlquery SQL query receiver receiver/sqlserver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants