[exporter/clickhouse] Add client info for identifying exporter in system.query_log#37146
Merged
Merged
Conversation
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Member
Author
|
not stale 👉 |
dmitryax
reviewed
Jan 25, 2025
…tor-contrib into ch-otel-user-agent
…tor-contrib into ch-otel-user-agent
…emetry-collector-contrib into ch-otel-user-agent
Member
Author
|
@dmitryax I have updated the code to use Overall the code is simpler though, let me know if anything else stands out. Thanks! |
atoulme
approved these changes
Feb 6, 2025
Contributor
atoulme
left a comment
atoulme
left a comment
There was a problem hiding this comment.
the changes look ok to me.
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Feb 21, 2025
yiquanzhou
added a commit
to dash0hq/opentelemetry-collector-contrib
that referenced
this pull request
Feb 24, 2025
* main: (55 commits) [chore] Update core dependencies (open-telemetry#38124) Add kafka topics observer implementation (open-telemetry#38060) [exporter/splunk_hec] Mute errors from draining the response body (open-telemetry#38118) [chore] [exporter/splunk_hec] Remove dead code (open-telemetry#38113) Add support for JUnit test results (open-telemetry#37941) [chore] amend changelog for prometheus receiver change (open-telemetry#38109) [chore] Fix dead links in issue-triaging.md (open-telemetry#38105) [chore] fix deprecation (open-telemetry#38107) [exporter/coralogix] Add new batch options to Coralogix exporter (open-telemetry#38082) [chore][exporter/datadog] fix integration test (open-telemetry#38091) [chore] Update otel to unblock contrib test in core repo (open-telemetry#38100) [chore] Bump go-version match to 1.23 (open-telemetry#38099) [exporter/elasticsearch] Add _metric_names_hash to avoid metric rejections (open-telemetry#37511) elasticsearchexporter: refactor encoding; drop metrics support from raw/none/bodymap mapping modes (open-telemetry#37928) [exporter/stefexporter] Fix incorrectly implemented STEF exporter zstd compression option (open-telemetry#38089) [exporter/clickhouse] Add client info for identifying exporter in `system.query_log` (open-telemetry#37146) [chore] Prepare release 0.120.1 (open-telemetry#38055) [extension/httpforwarder] Shutdown should wait server exit (open-telemetry#37735) receiver/prometheusremotewrite: Add two fields timestamp and value. (open-telemetry#37895) [reciver/sqlqueryreceiver] Add support for SapASE (sybase) (open-telemetry#37773) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
(reopen from #34915)
This change will include information about the collector version and OS/Arch for every
INSERT. Users can then track the origin of these queries insystem.query_log. For an official build this will look something likeotelcol/v0.114.0.This is implemented by setting
client_info_productin the DSN. The underlying ClickHouse Go driver will then attach it upon connection. Users can already add their own version info inendpointorconnection_params, but this change will now safely set or append to that value with the binary's information.Documentation:
client_product_infoTesting: