[chore] Update windows tests component groups#32518
Conversation
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
I'm glad there's no way at all to dig into the history of the code to figure out who to blame 😆
|
I've submitted #32520 to resolve the failing SQL Server unit tests on Windows. |
pjanotti
left a comment
pjanotti
left a comment
There was a problem hiding this comment.
It seems that more tests need to be skipped.
| GOMEMLIMIT: 2GiB | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - if: matrix.group == 'receiver-0' |
There was a problem hiding this comment.
Why remove the conditional? Is it needed for something other than receiver-0 group?
There was a problem hiding this comment.
I believe it is needed for the iis receiver, which changed to group 1, showing how the condition is fragile. I removed it so that in the future if the groups change again we wont have to worry about updating this condition. That does mean that all the groups get IIS installed. Since the tests don't run that often I thought that trade off was worth it.
There was a problem hiding this comment.
It adds something like 50s to 1m30s to each Windows unit test run I tend to see as waste, but, overall I think you are right: this extra time and compute seems acceptable in exchange for the consistency.
pjanotti
left a comment
pjanotti
left a comment
There was a problem hiding this comment.
LGTM as soon as any pending test skips are added
Co-authored-by: Curtis Robert <crobert@splunk.com>
Co-authored-by: Curtis Robert <crobert@splunk.com>
7 participants
Description:
Someone, and we may never know who, forgot to update the windows test groups when they created #30901
Fixes #32508