Skip to content

Double the number of exporter build-and-test groups#32496

Merged
mx-psi merged 6 commits into
open-telemetry:mainfrom
jmacd:jmacd/double_exporter_groups
Apr 23, 2024
Merged

Double the number of exporter build-and-test groups#32496
mx-psi merged 6 commits into
open-telemetry:mainfrom
jmacd:jmacd/double_exporter_groups

Conversation

@jmacd
Copy link
Copy Markdown
Contributor

@jmacd jmacd commented Apr 17, 2024

Description: Double the number of exporter test groups so that new tests can be added, e.g., the new tests in #31996.

Testing: These changes were applied in #31996 and they resolved a timeout.

@jmacd jmacd requested review from a team and atoulme April 17, 2024 20:53
@jmacd jmacd added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 17, 2024
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Apr 17, 2024
Comment thread Makefile
@crobert-1
Copy link
Copy Markdown
Member

Failing test is frequency of #27295, I've added it as frequency there.

Copy link
Copy Markdown
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update .github/workflows/build-and-test-windows.yml as well?

#32510 for context. cc @mx-psi

Copy link
Copy Markdown
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized you'll also need to update build-and-test-windows.yml with the new exporter groups.

@jmacd
Copy link
Copy Markdown
Contributor Author

jmacd commented Apr 18, 2024

Oh! The windows build-and-test appears out-of-date prior to my change--apparently was skipping some receiver tests.
See feb5ba2

@crobert-1
Copy link
Copy Markdown
Member

crobert-1 commented Apr 18, 2024

Oh! The windows build-and-test appears out-of-date prior to my change--apparently was skipping some receiver tests. See feb5ba2

You're right, we're fixing it in #32518 which is what made me remember this would need updated too. 👍

If possible, maybe only add the new groups to the Windows tests, and let the other PR add the rest? That way the changelog will be a bit more clear going forward.

Copy link
Copy Markdown
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the extra changes!

@mx-psi mx-psi added the Run Windows Enable running windows test on a PR label Apr 22, 2024
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Apr 22, 2024
@jmacd
Copy link
Copy Markdown
Contributor Author

jmacd commented Apr 22, 2024

=== Errors
multiple definitions of TestMain

@crobert-1
Copy link
Copy Markdown
Member

=== Errors
multiple definitions of TestMain

Should be fixed by #32603. Hopefully another rebase should fix it.

@mx-psi mx-psi merged commit 1401157 into open-telemetry:main Apr 23, 2024
@github-actions github-actions Bot added this to the next release milestone Apr 23, 2024
codeboten pushed a commit that referenced this pull request May 1, 2024
Description: Double the number of processor test groups so that new
tests can be added, e.g., the new tests in

#31946

Testing: These changes were applied in
#31946
and they appeared to help with spurious test timeouts.

Similar to
#32496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI, CD, testing, build issues ready to merge Code review completed; ready to merge by maintainers Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants