[chore][receiver/sqlserver] Skip tests failing on Windows#32520
Closed
crobert-1 wants to merge 1 commit into
Closed
[chore][receiver/sqlserver] Skip tests failing on Windows#32520crobert-1 wants to merge 1 commit into
crobert-1 wants to merge 1 commit into
Conversation
Member
Author
|
I didn't add |
TylerHelmuth
approved these changes
Apr 18, 2024
Member
|
@crobert-1 I want to make sure this skip works, so I'm gonna add these skips to #32518 |
Member
Author
Sounds good. That's probably a better place for it, and now we'll have this PR as the context/reference for it. |
Member
Author
|
This was completed in #32518 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
These tests were added as a part of #31915, functionality that has not yet been enabled in the collector. This means this code is not currently used, so the tests can be safely skipped on Windows for now, until they can be fixed as a part of the larger work going on in the receiver.
Link to tracking Issue:
#32519
#32518