fix: generate mock name for expanded resources

pkg/expansion/fixtures/fixtures.go

@@ -91,6 +91,7 @@ kind: Pod
 metadata:
   labels:
     app: nginx
+  name: nginx-deployment-pod
   namespace: default
 spec:
   containers:
@@ -108,6 +109,7 @@ kind: Pod
 metadata:
   labels:
     app: nginx
+  name: nginx-deployment-pod
   namespace: default
 spec:
   containers:
@@ -126,6 +128,7 @@ kind: Pod
 metadata:
   labels:
     app: nginx
+  name: nginx-deployment-pod
   namespace: default
 spec:
   containers:
@@ -145,6 +148,7 @@ metadata:
     app: nginx
   annotations:
     owner: admin
+  name: nginx-deployment-pod
   namespace: default
 spec:
   containers:
@@ -396,6 +400,7 @@ metadata:
     sound: meow
   labels:
     fluffy: extremely
+  name: big-chungus-kitten
   namespace: default
 spec:
   breed: calico
@@ -409,6 +414,7 @@ kind: Purr
 metadata:
   annotations:
     shouldPet: manytimes
+  name: big-chungus-purr
   namespace: default
 spec:
   loud: very

pkg/expansion/system.go

@@ -176,10 +176,25 @@ func expandResource(obj *unstructured.Unstructured, ns *corev1.Namespace, templa
 	resource.SetUnstructuredContent(src)
 	resource.SetGroupVersionKind(resultantGVK)
 	resource.SetNamespace(ns.Name)
+	resource.SetName(mockNameForResource(obj, resultantGVK))
 
 	return resource, nil
 }
 
+// mockNameForResource returns a mock name for a resultant resource created
+// from expanding `gen`. The name will be of the form:
+// "<generator name>-<resultant kind>". For example, a deployment named
+// `nginx-deployment` will produce a resultant named `nginx-deployment-pod`.
+func mockNameForResource(gen *unstructured.Unstructured, gvk schema.GroupVersionKind) string {
+	name := gen.GetName()
+	if gvk.Kind != "" {
+		name += "-"
+	}
+	name += gvk.Kind
+
+	return strings.ToLower(name)
+}
+
 func NewSystem(mutationSystem *mutation.System) *System {
 	return &System{
 		lock:           sync.RWMutex{},

test/gator/expand/fixtures/basic-expansion-nonmatching-configs/output/output.yaml

@@ -3,6 +3,7 @@ kind: Pod
 metadata:
   labels:
     app: nginx
+  name: nginx-deployment-pod
 spec:
   containers:
   - args:

test/gator/expand/fixtures/basic-expansion/output/output.yaml

@@ -5,6 +5,7 @@ metadata:
     owner: admin
   labels:
     app: nginx
+  name: nginx-deployment-pod
 spec:
   containers:
   - args:

test/gator/expand/fixtures/expand-cr/output/output.yaml

@@ -3,6 +3,7 @@ kind: Purr
 metadata:
   annotations:
     shouldPet: manytimes
+  name: big-chungus-purr
 spec:
   loud: very
 ---
@@ -13,6 +14,7 @@ metadata:
     sound: meow
   labels:
     fluffy: extremely
+  name: big-chungus-kitten
 spec:
   age: 10
   breed: calico

test/gator/expand/fixtures/expand-with-ns/output/output.yaml

@@ -3,6 +3,7 @@ kind: Pod
 metadata:
   labels:
     app: nginx
+  name: nginx-deployment-pod
   namespace: my-ns
 spec:
   containers: