fix: add eshe_instructor to allowedRoles [BB-7489]

[0x29a]

Port of 0x29a#1 to Palm.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (opencraft-release/palm.1@3644172). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@                     Coverage Diff                      @@
##             opencraft-release/palm.1        #1   +/-   ##
============================================================
  Coverage                            ?   100.00%           
============================================================
  Files                               ?       122           
  Lines                               ?      1269           
  Branches                            ?       251           
============================================================
  Hits                                ?      1269           
  Misses                              ?         0           
  Partials                            ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Agrendalath]

@0x29a, can we rename this branch from opencraft-release/palm.1 to opencraft-release/palm.1-eshe? This change is specific to the client, so we don't want anyone else to use it.

I'm asking because I just pushed the opencraft-release/palm.1-echo branch, which includes the @edx/frontend-platform version bump from 2.5.0 to ^4.2.0. An older version of the @edx/frontend-platform breaks the deployment when using a custom header/footer for the MFEs. Therefore, I considered calling that branch opencraft-release/palm.1 instead so everyone can use it.

[0x29a]

@Agrendalath, sure, we can. This feature is gated, so other clients shouldn't notice any changes. We added it to our shared branch to avoid having a client-specific branch. Should I create a ticket for the next sprint to extract these changes to a separate branch?

[Agrendalath]

@0x29a, ah, thanks for clarifying. If the allowedRoles are not visible anywhere in this MFE (outside of the source code), it's OK to keep it as-is.

[0x29a]

@Agrendalath, yep, allowedRoles is used only to allow or block access to the gradebook depending on roles that some particular user posses.