Skip to content

fix: add eshe_instructor to allowedRoles - #14

Merged
ArturGaspar merged 1 commit into
opencraft-release/redwood.1from
artur/eshe-instructor-redwood
Jul 22, 2024
Merged

fix: add eshe_instructor to allowedRoles#14
ArturGaspar merged 1 commit into
opencraft-release/redwood.1from
artur/eshe-instructor-redwood

Conversation

@ArturGaspar

@ArturGaspar ArturGaspar commented Jul 10, 2024

Copy link
Copy Markdown

Description

eSHE Instructors can't view the gradebook without this.

Port of #1 to Redwood.

Supporting information

#1

Testing instructions

  1. Use feat: port code drift for open-craft/edx-platform [BB-8914] openedx-platform#666 branch (0x29a/bb8914/redwood-code-drift) of edx-platform.
  2. Enable feature ENABLE_ESHE_INSTRUCTOR_ROLE (see below for example Tutor plugin).
  3. Enroll as a student in a course.
  4. Enroll a non-staff user as an eSHE instructor:
    1. Go to course.
    2. Go to Instructor tab.
    3. Go to section "Course Team Management".
    4. Select role "eSHE Instructor", input username and enroll.
  5. Log in as the user enrolled in step 4.
  6. Go to course.
  7. Go to Instructor tab.
  8. Go to "Student Admin" tab.
  9. Click "View Gradebook".
  10. See that you can view the enrolled student from step 3 in the gradebook.
Example Tutor plugin to enable required feature
name: eshe
version: 0.1.0
patches:
  openedx-common-settings: |
    FEATURES["ENABLE_ESHE_INSTRUCTOR_ROLE"] = True

Deadline

2024-07-22

Other information

Private-ref: https://tasks.opencraft.com/browse/BB-8934

eSHE Instructors can't view the gradebook without this.
@ArturGaspar
ArturGaspar marked this pull request as ready for review July 15, 2024 15:12

@tecoholic tecoholic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturGaspar 👍

  • I tested this: Followed the testing instructions and verified that the eshe Instructor can access the gradebook and see learners
  • I read through the code
  • I checked for accessibility issues - NA
  • Includes documentation - NA
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository. - NA

@ArturGaspar
ArturGaspar merged commit a197437 into opencraft-release/redwood.1 Jul 22, 2024
@ArturGaspar
ArturGaspar deleted the artur/eshe-instructor-redwood branch August 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants