fix: add eshe_instructor to allowedRoles - #14
Merged
ArturGaspar merged 1 commit intoJul 22, 2024
Conversation
eSHE Instructors can't view the gradebook without this.
ArturGaspar
marked this pull request as ready for review
July 15, 2024 15:12
tecoholic
approved these changes
Jul 22, 2024
tecoholic
left a comment
Member
There was a problem hiding this comment.
- I tested this: Followed the testing instructions and verified that the
eshe Instructorcan access the gradebook and see learners - I read through the code
- I checked for accessibility issues - NA
- Includes documentation - NA
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository. - NA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
eSHE Instructors can't view the gradebook without this.
Port of #1 to Redwood.
Supporting information
#1
Testing instructions
0x29a/bb8914/redwood-code-drift) of edx-platform.ENABLE_ESHE_INSTRUCTOR_ROLE(see below for example Tutor plugin).Example Tutor plugin to enable required feature
Deadline
2024-07-22
Other information
Private-ref: https://tasks.opencraft.com/browse/BB-8934