Skip to content

fix: add eshe_instructor to allowedRoles [BB-7489] - #1

Merged
0x29a merged 1 commit into
opencraft-release/nutmeg.2from
0x29a/bb7489/eshe-instructor
Aug 14, 2023
Merged

0x29a merged 1 commit into
opencraft-release/nutmeg.2from
0x29a/bb7489/eshe-instructor

Conversation

@0x29a

@0x29a 0x29a commented Aug 13, 2023

Copy link
Copy Markdown
Owner

eSHE Instructors can't view the gradebook without this.

Note: this is my personal fork. Once open-craft/frontend-app-gradebook is shared with OpenCraft Core group, I'll push opencraft-release/nutmeg.2 there.

eSHE Instructors can't view the gradebook without this.
0x29a added a commit to open-craft/tutor-mfe that referenced this pull request Aug 13, 2023
In particular, this is needed to apply eSHE Instructor fix: 0x29a/frontend-app-gradebook#1
0x29a added a commit to open-craft/tutor-mfe that referenced this pull request Aug 13, 2023
In particular, this is needed to apply eSHE Instructor fix: 0x29a/frontend-app-gradebook#1
@Cup0fCoffee

Copy link
Copy Markdown

👍

  • I tested this
  • I read through the code
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@0x29a
0x29a merged commit 3a77c5f into opencraft-release/nutmeg.2 Aug 14, 2023
@0x29a
0x29a deleted the 0x29a/bb7489/eshe-instructor branch August 14, 2023 13:52
@0x29a

0x29a commented Aug 14, 2023

Copy link
Copy Markdown
Owner Author

Merged. opencraft-release/nutmeg.2 branch will be pushed to open-craft/frontend-app-gradebook as soon as I have a permission to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants