Update to flow-go with go-ethereum@v1.14.8#786
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request refactors the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
go.sumis excluded by!**/*.sumtests/go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
api/debug.go(1 hunks)go.mod(4 hunks)tests/go.mod(4 hunks)
🔇 Additional comments (12)
api/debug.go (3)
220-220: Updated to use direct method call instead of pointer dereferencingThe code now uses
account.Balance.ToInt()directly instead of dereferencing the pointer. This is a cleaner approach and likely adapts to API changes in the updated go-ethereum dependency.
227-228: Direct state object usage replaces pointer dereferencingUpdated to append
account.Statedirectly, which matches the expected API interface in the updated dependencies and improves code clarity.
231-232: Direct stateDiff object usage replaces pointer dereferencingUpdated to append
account.StateDiffdirectly instead of dereferencing a pointer. This change aligns with the updated API interface in go-ethereum v1.14.8.go.mod (5)
10-10: Updated Cadence dependency versionUpdated
github.com/onflow/cadencefrom v1.3.1 to v1.3.3 to maintain compatibility with the latest Flow ecosystem components.
12-12: Updated Flow SDK dependency versionUpdated
github.com/onflow/flow-go-sdkfrom v1.3.1 to v1.3.3 to maintain compatibility with the latest changes in the Flow ecosystem.
97-97: Updated uint256 dependency versionUpdated
github.com/holiman/uint256from v1.3.0 to v1.3.1, which is likely required for compatibility with the updated go-ethereum version.
144-145: Updated Flow core contracts dependenciesUpdated both contracts and templates packages from v1.5.1-preview to v1.6.0 stable release, which provides more reliable contract implementations.
150-150: Updated Flow protobuf dependencyUpdated
github.com/onflow/flow/protobuf/go/flowfrom v0.4.9 to v0.4.10 to maintain compatibility with the latest protocol updates.tests/go.mod (4)
7-8: Updated Flow ecosystem dependencies in test moduleUpdated Cadence, Flow, and Flow SDK versions to match those in the main module, ensuring consistent behavior between main code and tests.
Also applies to: 11-12
103-103: Updated uint256 dependency version in test moduleUpdated
github.com/holiman/uint256from v1.3.0 to v1.3.1 to match the dependency in the main module.
154-155: Updated Flow core contracts dependencies in test moduleUpdated both contracts and templates packages from v1.5.1-preview to v1.6.0 stable release in the test module to match the main module.
160-160: Updated Flow protobuf dependency in test moduleUpdated
github.com/onflow/flow/protobuf/go/flowfrom v0.4.9 to v0.4.10 to maintain consistency with the main module.
b5201ae to
414bcc0
Compare
| // Override account balance. | ||
| if account.Balance != nil { | ||
| opts = append(opts, query.WithStateOverrideBalance(addr, (*big.Int)(*account.Balance))) | ||
| opts = append(opts, query.WithStateOverrideBalance(addr, account.Balance.ToInt())) |
There was a problem hiding this comment.
The changes in this file come from: ethereum/go-ethereum@ac0f220#diff-c426ecd2f7d247753b9ea8c1cc003f21fa412661c1f967d203d4edf8163da344
414bcc0 to
62ed404
Compare
62ed404 to
e2a3d68
Compare
Work towards: onflow/flow-go#7152
Depends on: onflow/go-ethereum#8
Description
Updates to
flow-goversion usinggo-ethereum@v1.14.8and fixes some minor breaking changes.For contributor use:
masterbranchFiles changedin the Github PR explorerSummary by CodeRabbit
Refactor
Chores