Update to Cadence v1.7.0-preview.1#870
Conversation
turbolent
requested review from
janezpodhostnik,
m-Peter,
peterargue and
zhangchiqing
as code owners
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/go.mod (1)
3-3: Nit: thegodirective should be minor-only (“1.23”), not “1.23.7”.Go’s
godirective encodes the language version at the minor level; patch level belongs in thetoolchaindirective (which you already have at Line 5). This isn’t introduced by this PR, but adjusting helps avoid tooling warnings.Apply this minimal change:
-go 1.23.7 +go 1.23
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
tests/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
tests/go.mod(2 hunks)
🔇 Additional comments (1)
tests/go.mod (1)
160-161: Base-version alignment confirmedBoth indirect dependencies for
flow-core-contractsintests/go.modare now pinned to the same pseudo-version (v0.0.0-20250807122906-29940d8821f0), matching commit 29940d8821f0 and preventing any “patch-only” updater confusion.Diff in
tests/go.mod(lines 160–161):- github.com/onflow/flow-core-contracts/lib/go/contracts v1.7.4-0.20250807122906-29940d8821f0 // indirect - github.com/onflow/flow-core-contracts/lib/go/templates v1.7.2-0.20250807122906-29940d8821f0 // indirect + github.com/onflow/flow-core-contracts/lib/go/contracts v0.0.0-20250807122906-29940d8821f0 // indirect + github.com/onflow/flow-core-contracts/lib/go/templates v0.0.0-20250807122906-29940d8821f0 // indirectNo further changes needed.
| github.com/onflow/cadence v1.7.0-preview.1 | ||
| github.com/onflow/crypto v0.25.3 | ||
| github.com/onflow/flow-emulator v1.5.2-0.20250620100838-4e2f7bc18c24 | ||
| github.com/onflow/flow-emulator v1.7.0-preview.1 |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Emulator bump aligns with Cadence/SDK targets; verify runtime compatibility in CI.
Upgrading to github.com/onflow/flow-emulator v1.7.0-preview.1 matches the PR objective and the Cadence v1.7.0-preview.1 + flow-go-sdk v1.7.0 matrix. As this is a preview, please confirm no breaking changes in emulator flags/defaults impact test bootstrapping (e.g., account key formats, gas or storage limits).
Run these quick checks from the repo root to ensure module resolution and emulator boots with the expected version:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
pushd tests >/dev/null
# 1) Resolve and vendor to catch any mismatches early
go mod tidy
go mod download
# 2) Inspect resolved versions
go list -m -json github.com/onflow/cadence github.com/onflow/flow-go-sdk github.com/onflow/flow-emulator | jq -r '.Path + " " + .Version'
# 3) Smoke start the emulator (fails fast if flags/behaviour changed)
# Note: adjust flags to whatever your tests expect, this is a minimal boot.
go run github.com/onflow/flow-emulator/cmd/emulator@v1.7.0-preview.1 --help >/dev/null
popd >/dev/nullLength of output: 23044
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Navigate into the tests module
pushd tests >/dev/null
# 1) Verify module versions without modifying go.mod
echo "Resolved module versions:"
go list -m -f '{{.Path}} {{.Version}}' github.com/onflow/cadence
go list -m -f '{{.Path}} {{.Version}}' github.com/onflow/flow-go-sdk
go list -m -f '{{.Path}} {{.Version}}' github.com/onflow/flow-emulator
popd >/dev/null
# 2) Smoke‐start the emulator to ensure no breaking flag/default changes
echo "Launching emulator help (no output means success):"
go run github.com/onflow/flow-emulator/cmd/emulator@v1.7.0-preview.1 --help >/dev/null
echo "Emulator started successfully."Length of output: 1146
Smoke run failed: emulator v1.7.0-preview.1 does not compile due to missing BLS symbols
Attempting to start the emulator with the bumped preview release uncovered compile-time errors in the onflow/crypto module—symbols like blsInstance, initBLS12381 and isG2Compressed are undefined, causing the bootstrap to fail.
Please address the following before merging:
• tests/go.mod
– Emulator bumped to v1.7.0-preview.1 pulls in github.com/onflow/crypto v0.25.3, which lacks the new BLS APIs used by the emulator.
– Update the crypto dependency to a version that provides the missing BLS symbols (e.g. bump to a crypto release ≥v0.26.x that includes BLS12381 support), or vendor in the required commits.
• Verify that after adjusting the dependency, the emulator compiles and go run … --help succeeds without errors.
🤖 Prompt for AI Agents
In tests/go.mod around line 12, the Flow emulator was bumped to v1.7.0-preview.1
but the transitive github.com/onflow/crypto version (v0.25.3) lacks the BLS
symbols (blsInstance, initBLS12381, isG2Compressed); update the crypto
dependency to a release that includes BLS12381 support (bump
github.com/onflow/crypto to ≥ v0.26.x or a specific tag that contains the BLS
APIs), then run go get github.com/onflow/crypto@<new-version> (or vendor the
necessary commits), run go mod tidy, and verify the emulator builds and runs
(e.g., go build ./... and go run ./cmd/emulator --help) with no undefined symbol
errors before merging.
m-Peter
left a comment
m-Peter
left a comment
There was a problem hiding this comment.
Using https://github.com/onflow/flow-emulator/releases/tag/v1.7.0-preview.2 should hopefully make the CI ✔️
3 participants
Description
Automatically update to:
Summary by CodeRabbit