Skip to content

Update to Cadence v1.6.2#832

Merged
m-Peter merged 3 commits into
mainfrom
auto-update-onflow-cadence-v1.6.2
Jun 25, 2025
Merged

Update to Cadence v1.6.2#832
m-Peter merged 3 commits into
mainfrom
auto-update-onflow-cadence-v1.6.2

Conversation

@jribbink
Copy link
Copy Markdown
Contributor

@jribbink jribbink commented Jun 19, 2025

Description

Automatically update to:

Summary by CodeRabbit

  • Chores
    • Updated multiple dependencies to newer versions for improved stability and compatibility.
    • Added and removed several indirect dependencies to align with the latest library standards.
    • Enhanced test account setup for more efficient transaction handling in the emulator.
    • No changes to user-facing features or functionality.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 19, 2025

Walkthrough

This change updates the go.mod and tests/go.mod files to refresh and upgrade multiple dependencies, particularly those related to Flow, Cadence, Google Cloud, and OpenTelemetry. Some obsolete dependencies were removed, and several new indirect dependencies were added, aligning the project with more recent library versions. Additionally, the Cadence transaction code in tests/helpers.go was modified to centralize the creation and capability publishing of a CadenceOwnedAccount in the prepare phase, improving reuse and removing redundant steps in the execute phase.

Changes

Files Change Summary
go.mod, tests/go.mod Upgraded Flow, Cadence, Flow Emulator, Flow Go SDK, and multiple Google Cloud and telemetry dependencies. Added new indirect dependencies (e.g., cloud.google.com/go/auth). Removed outdated or replaced modules (e.g., groupcache, go.opencensus.io, msgpack v4.0.4+incompatible).
tests/helpers.go Modified Cadence transaction code in setupTestAccounts to create and publish CadenceOwnedAccount capability in prepare phase, reusing it in execute, removing redundant creation and publishing steps.

Possibly related PRs

  • #754: Updates github.com/onflow/flow-go dependency versions, related to core Flow dependency upgrades.
  • #301: Refreshes Flow and Cadence dependencies in module files, similar dependency version updates.
  • #341: Upgrades core Flow dependencies in go.mod and tests/go.mod, related to dependency management.

Suggested labels

Improvement

Suggested reviewers

  • janezpodhostnik
  • peterargue
  • zhangchiqing

Poem

🐇 In code’s green meadow, dependencies bloom,
Flow and Cadence dance, dispelling the gloom.
Capabilities set early, no need to repeat,
Efficiency hops in with nimble feet.
A rabbit’s delight in each tidy line,
Fresh versions and logic, perfectly fine! 🌿✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package crypto: could not load export data: no export data for "github.com/onflow/crypto""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package crypto: could not load export data: no export data for "github.com/onflow/crypto""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8d8c37 and ff8deac.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • go.mod (4 hunks)
  • tests/go.mod (4 hunks)
  • tests/helpers.go (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • tests/helpers.go
  • go.mod
  • tests/go.mod
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Test
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e822141 and a70ced2.

📒 Files selected for processing (1)
  • tests/helpers.go (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Test
🔇 Additional comments (4)
tests/helpers.go (4)

233-233: LGTM: Good addition of COA field for reuse.

Adding the coa field to store the borrowed CadenceOwnedAccount reference is a good practice that enables reuse across the transaction phases.


255-256: LGTM: Proper COA borrowing and storage.

The COA is correctly borrowed from storage and assigned to the field for reuse in the execute phase.


259-259: LGTM: Efficient reuse of pre-borrowed COA.

Using the pre-borrowed self.coa reference instead of borrowing inline is more efficient and cleaner.


262-267: LGTM: Consistent use of pre-borrowed COA reference.

The call operation correctly uses the pre-borrowed COA reference, maintaining consistency with the refactored approach.

Comment thread tests/helpers.go Outdated
Comment thread tests/helpers.go Outdated
@jribbink jribbink force-pushed the auto-update-onflow-cadence-v1.6.2 branch from 6f0fba8 to ad0e2cb Compare June 19, 2025 07:50
@m-Peter m-Peter self-assigned this Jun 20, 2025
@m-Peter m-Peter force-pushed the auto-update-onflow-cadence-v1.6.2 branch from f410114 to e8d8c37 Compare June 20, 2025 10:28
@m-Peter
Copy link
Copy Markdown
Collaborator

m-Peter commented Jun 20, 2025

@jribbink I hope you don't mind, but I jumped in to lend a helping hand.

For some reason, possibly a bug or something, the process that deploys the VM Bridge and related Solidity contracts, ends up creating an EVM block, that doesn't have those EVM transactions. Not sure why, I'll have to investigate when I have some time.

However, even if this process works properly, we still do not want to deploy those VM Bridge related contracts, as it will cause the entire E2E tests of EVM GW to fail 😅 .

I disabled the SetupVMBridgeEnabled flag in e8d8c37, but it turns out that there's a bug on Flow Emulator, that doesn't allow setting this flag to false.

I opened onflow/flow-emulator#827 to address that, and as you can see the CI is ✔️ again .

Could you take a look at that, so we can unblock any new Flow CLI releases? 🙏

@m-Peter m-Peter force-pushed the auto-update-onflow-cadence-v1.6.2 branch from e8d8c37 to ff8deac Compare June 25, 2025 09:32
Copy link
Copy Markdown
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m-Peter m-Peter merged commit c732a56 into main Jun 25, 2025
2 checks passed
@m-Peter m-Peter deleted the auto-update-onflow-cadence-v1.6.2 branch June 25, 2025 13:17
@coderabbitai coderabbitai Bot mentioned this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants