Update to Cadence v1.6.2#832
Conversation
WalkthroughThis change updates the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package crypto: could not load export data: no export data for "github.com/onflow/crypto"" 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/helpers.go(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test
🔇 Additional comments (4)
tests/helpers.go (4)
233-233: LGTM: Good addition of COA field for reuse.Adding the
coafield to store the borrowed CadenceOwnedAccount reference is a good practice that enables reuse across the transaction phases.
255-256: LGTM: Proper COA borrowing and storage.The COA is correctly borrowed from storage and assigned to the field for reuse in the execute phase.
259-259: LGTM: Efficient reuse of pre-borrowed COA.Using the pre-borrowed
self.coareference instead of borrowing inline is more efficient and cleaner.
262-267: LGTM: Consistent use of pre-borrowed COA reference.The call operation correctly uses the pre-borrowed COA reference, maintaining consistency with the refactored approach.
6f0fba8 to
ad0e2cb
Compare
f410114 to
e8d8c37
Compare
|
@jribbink I hope you don't mind, but I jumped in to lend a helping hand. For some reason, possibly a bug or something, the process that deploys the VM Bridge and related Solidity contracts, ends up creating an EVM block, that doesn't have those EVM transactions. Not sure why, I'll have to investigate when I have some time. However, even if this process works properly, we still do not want to deploy those VM Bridge related contracts, as it will cause the entire E2E tests of EVM GW to fail 😅 . I disabled the I opened onflow/flow-emulator#827 to address that, and as you can see the CI is ✔️ again . Could you take a look at that, so we can unblock any new Flow CLI releases? 🙏 |
e8d8c37 to
ff8deac
Compare
Description
Automatically update to:
Summary by CodeRabbit