Merge in latest changes from bcoin #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pool.getBroadcasted() error item.hash is not a function
Use cache only when installing Use workspaces to share node_modules
spvnode: add new option `file` instead of config
bin: handle close when interrupted
pkg: update ci
circleci: fix eslint
Allow optional signing in createTX http endpoint
* browser: update since refactor * docs: redirect browser to new guide
matches expected outputs from hsd
bcoin browser mode can not use DNS to discover seeds, so they are hard-coded. see: https://github.com/bcoin-org/bdns/blob/master/lib/dns-browser.js#L23 There's already plenty in `/lib/net/seeds/main.js` so this is just to get browser-nodes running on testnet. Seeds were pulled from my own `hosts.json` file on a live testnet bcoin node
Currently coinview does not account for spent coins in the mempool, This does not create problems because we have additional checks in right places which detect double spends, but technically coinview should help you detect double spent in the mempool as well. This way it will be compatible with chain.getCoinView. getSpentView will still return all outputs that are available in the mempool. (This could also return spentView from indexers if available, this method is used by `signrawtransaction`.)
Addresses confusion similar to bcoin-org/bcoin-docker#8
pkg: add lockfile
bench: remove chacha that is out of the scope, it was part of the bip151 implementation. test: increase timeouts.
Dependency updates, support node v12
Add net tests
node: use the same memory option
Remove test assert util and use bsert
Minor RPC Test updates
move hasRaw check to txindexer
add ability to track listeners and remove them on close for indexer
docs: update max-inbound default
|
Closed as there is another MR that handles these changes here: #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Large breaking changes are included. Databases are stored differently and servers running old fcoin versions MUST be upgraded, or they will be forced to sync again.