browser: update since refactor #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
bucko13
approved these changes
Nov 1, 2018
tuxcanfly
pushed a commit
to tuxcanfly/bcoin
that referenced
this pull request
Jan 19, 2019
* browser: update since refactor * docs: redirect browser to new guide
tuxcanfly
pushed a commit
to tuxcanfly/bcoin
that referenced
this pull request
Apr 19, 2019
* browser: update since refactor * docs: redirect browser to new guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny fixes are needed to run bcoin in a browser.
The location of the
app.jsfile gets confused in some browsers when running locally (Chrome kept trying to access/app.jsas an absolute pathfile:///app.js)Since the big refactor this year and use of bclient for RPC calls, the object returned from RPC calls is slightly different and was always being displayed as
null.An update to
blgris also required for bcoin-in-browser to work:bcoin-org/blgr#1, which re-adds the method
logger.format()after it was refactored out a few months ago. This seems to be the cleanest way of restoring the in-page logger functionality.These changes have been tested on local and a remote server, and functionality has been described in a new bcoin.io guide (pending merge): bcoin-org/bcoin-org.github.io#122 and so I added a second commit (optional) that redirects users to the longer, more detailed guide.