Fixes pool.getBroadcasted() error item.hash is not a function #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Sounds like a pretty important bug. Weird that it slipped through all tests. Thanks! |
tuxcanfly
requested changes
Aug 31, 2018
test/node-test.js
Outdated
| }); | ||
| const txItem = new InvItem(invTypes.TX, tx1.hash()); | ||
| await node.sendTX(tx1); // add TX to inventory | ||
| node.pool.getBroadcasted(dummyPeer, txItem); |
There was a problem hiding this comment.
Could use an assert on returned tx vs tx2.id().
|
updated and squashed |
tuxcanfly
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was uncovered by @OrfeasLitos in progress of writing this guide, in which an error is thrown when a peer requests a transaction from the inventory:
[D:2018-08-27T19:15:36Z] (net) Error: item.hash is not a function (127.0.0.1:55362)The bug was introduced 20 days ago in a0ac953 and prevents all transaction broadcasting to peers!
Thanks to @tuxcanfly for finding the bug and checking for other occurrences (none found yet!)
Test is a little funny but it's the only way I could figure to hit that exact line.