Repository navigation
fix(docs): remove white gap in homepage demo terminal (light mode) - #303
Merged
Merged
Conversation
Blume's global stylesheet applies a default top/bottom margin to <img> elements (for prose spacing). Since .demo-terminal has overflow:hidden and a transparent background, that margin pushed the demo GIF down, exposing a gap between the dark title bar and the dark GIF content — invisible in dark mode (page background is also dark) but a glaring white band in light mode. Reset margin to 0 and set display:block explicitly on .demo-terminal img. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe documentation homepages for English and Japanese add ChangesTerminal Demo Styling
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a visual bug on the deployed homepage, reported after merging #296: in light mode, the demo terminal's dark title bar and dark GIF content had a jarring white gap between them.
Root cause: Blume's global stylesheet applies a default top/bottom margin to
<img>elements..demo-terminalhasoverflow: hiddenand a transparent background, so that margin pushed the demo GIF down, exposing the transparent container's background (= page background) between the title bar and the image — invisible in dark mode (page background is also dark) but a visible white band in light mode.Fix: reset
margin: 0and setdisplay: blockexplicitly on.demo-terminal imgin bothindex.mdxandja/index.mdx.Test plan
data-theme="light"blume devthat the gap is gone after the fix, in both light and dark modepnpm lintpasses.theme-imgscreenshots are unaffected (different container, no regression there)🤖 Generated with Claude Code
Summary by CodeRabbit